555517 - no keyboard accelerators to dismiss Troublehsoot Mode dialog

Status: NEW

(Toolkit :: Startup and Profile System, defect)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a4pre) Gecko/20100327  Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a4pre) Gecko/20100327  Minefield/3.7a1pre

I often start with -safe-mode, and it's irritating that I can't [Continue in Safe Mode] or [Make Changes and Restart] from the keyboard.  It seems chrome://browser/content/safeMode.xul lacks access keys for these dialog buttons.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox using `firefox -safe-mode`
2. Try to dismiss the dialog from the keyboard.

Actual Results:  
You can't activate [Continue in Safe Mode] or [Make Changes and Restart] from the keyboard except by tabbing to it.  I think pressing <Esc> will Quit (taking down the entire browser if you're viewing the .xul file!).

Expected Results:  
An underlined letter in [Continue in Safe Mode] or [Make Changes and Restart] that's the keyboard accelerator.

I think this is just an oversight, e.g. chrome://mozapps/content/extensions/extensions.xul has 
accesskey="&cmd.continue.accesskey;" defined in extensions.dtd.

I found some other XUL dialogs in chrome://browser/content without keyboard accelerators for their dismiss buttons, but lost 'em and this bug report when I pressed Esc :-)

Comment 1

[skierpage]

Still present in Mozilla/5.0 (X11; Linux x86_64; rv:12.0a1) Gecko/20120104 Firefox/12.0a1

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to skierpage from comment #1)

Still present in Mozilla/5.0 (X11; Linux x86_64; rv:12.0a1) Gecko/20120104
Firefox/12.0a1

Still an issue in current version?

Comment 3

[skierpage]

(In reply to Wayne Mery (:wsmwk) from comment #2)

Still an issue in current version?
Yes, still present in Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

The buttons are now [Refresh Nightly] and [Start in Safe Mode], still without accelerators.
The command-line switch now has two dashes, --safe-mode.

Please try either steps to repeat (start in Safe mode or just open chrome://browser/content/safeMode.xul) and you should be able to change this bug to Confirmed. Thanks.

Comment 4

[Wayne Mery (:wsmwk)]

Walt, skierpage, does this still reproduce? (I don't have linux)

Comment 5

[skierpage]

(In reply to Wayne Mery (:wsmwk) from comment #4)

Walt, skierpage, does this still reproduce? (I don't have linux)

With Nightly 97.0a1 under Wayland, the [Refresh Nightly] and [Open] buttons still lack an underlined letter that's the accelerator. So this minor bug still exists.

I would think all platforms would show the bug if you start FIrefox from a terminal with the command-line switch.

Comment 6

[WaltS48 [:walts48]]

Attachment: safe-mode.png

Firefox Nightly 97.0a1 on Fedora 35 Workstation, Gnome 41 desktop.

Comment 7

[WaltS48 [:walts48]]

Attachment: thunderbird-daily.png

Thunderbird Daily 97.0a1.