555528 - Flag FatPlug code in the validator and make it clear it's not allowed

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Policy, defect, P2)

Description

[Johannes Buchner]

I received a unsolicited email from the author of http://fatplug.com/, inviting me to include the "ad swapping" into an add-on of mine.

I assume that many other addon writers received such an email, and some will follow the money. As such, addon reviewers, expect to see the include lines of fatplug, and think about whether such activity is allowed (The relevant question is: Does the end-user want it?). 

I would welcome a discussion/position/policy.

Comment 1

[Johannes Buchner]

https://addons.mozilla.org/en-US/firefox/addon/10830
"Really enjoy this addon, but noticed the license agreement in the new v0.6 states the addon will replace adverts displayed in other webpages - does anyone have any more detail of what this means? Is the addon tracking my browsing?

Rated 4 out of 5 stars by oktup on March 27, 2010 "

As long as the license agreement mentions it, it is ok?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

We're looking into this. In the mean time, all add-on versions implementing this feature will remain in the sandbox.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Adding amo-editors flag. Sorry for the spam.

Comment 4

[Josh Carr]

@jorge this is Josh Carr from fatplug.com. I just sent you an email with more detail but we would love to be included in this discussion.

Please let me know if you have any questions and what your concerns are. I apologize for the spam we had a team member who got excited and was trying to be helpful. About 50 messages went out before we realized it and had her stop.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

We have reached a decision and FatPlug will not be allowed. All add-ons or
add-on versions including FatPlug will be disabled.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Changes in the policy page will be included in bug 547306.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1. Added check for fatplug_bootstrap function

Trivial patch.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Fixed, r65370.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...