Closed Bug 555939 Opened 12 years ago Closed 12 years ago

Make about: link SeaMonkey website and relnotes

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(blocking-seamonkey2.1 a3+)

RESOLVED FIXED
seamonkey2.1a3
Tracking Status
blocking-seamonkey2.1 --- a3+

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file, 1 obsolete file)

As about: is the main "About SeaMonkey" location (we don't have a separate dialog), we really want to have our website and the relnotes linked there.

If bug 349985 doesn't work out until our next milestone, I have a patch in store that forks about.xhtml and calls it with chrome privs and script always enabled, so that we get what we need there.
Flags: blocking-seamonkey2.1a1?
Here's my patch we can take if the global stuff doesn't work out as we'd like.
> +#expand <p id="version">&about.version; __MOZ_APP_VERSION__</p>

You know if we have chrome privileges we can just do:

document.getElementById("version"))
        .textContent ="&about.version; " + Application.version;

No need to pre-process the file.
Flags: blocking-seamonkey2.1a1? → blocking-seamonkey2.1a1+
Philip, sure, we could look into that, but for now I copied what the global about.xhtml does, as the patch here is considered to be just a wallpaper over toolkit not getting things we need, I don't consider the patch a real solution to the problem. And as I still have a small amount of hope that toolkit might do something, this isn't even up for review, it's just here for potentially picking up later.
blocking-seamonkey2.1: --- → a1+
Flags: blocking-seamonkey2.1a1+
pushing off to a2, as bug 349985 is only waiting for sr right now.
blocking-seamonkey2.1: a1+ → a2+
Target Milestone: seamonkey2.1a1 → seamonkey2.1a2
Comment on attachment 435877 [details] [diff] [review]
fork about.xhtml and make it take over about: with chrome privs

untested, but everything looks right. And I'd love to have this working in a2; but I'm ok with pushing off for a3 pending the about:* privs bug.
Attachment #435877 - Flags: review+
[now that we have an a3 flag, I'm happier pushing the blocking status off, but still would be good for a2]
blocking-seamonkey2.1: a2+ → a3+
Target Milestone: seamonkey2.1a2 → seamonkey2.1a3
This just updates for entity changes made on the toolkit version in bug 435550.

I'm now tired of waiting for the security sr from dveditz in the other bug, but requesting sr from Neil to make sure we don't load release notes with chrome privs when clicking the link, I hope he can confirm my assumption that we safely go back to normal content privs when following such a link there.

I'm also thinking about things we could do with this about: tab that possibly deviate from the general toolkit file anyhow, so there might be more than the original reason in the future to have this override in place.
Attachment #435877 - Attachment is obsolete: true
Attachment #460931 - Flags: superreview?(neil)
Attachment #460931 - Flags: review+
Attachment #460931 - Flags: superreview?(neil) → superreview+
Pushed as http://hg.mozilla.org/comm-central/rev/fa58a55a530b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I forgot to package the new file, fixed that up in http://hg.mozilla.org/comm-central/rev/ab62e1205358
You need to log in before you can comment on or make changes to this bug.