Make about: link SeaMonkey website and relnotes

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
UI Design
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

unspecified
seamonkey2.1a3

Firefox Tracking Flags

(blocking-seamonkey2.1 a3+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
As about: is the main "About SeaMonkey" location (we don't have a separate dialog), we really want to have our website and the relnotes linked there.

If bug 349985 doesn't work out until our next milestone, I have a patch in store that forks about.xhtml and calls it with chrome privs and script always enabled, so that we get what we need there.
Flags: blocking-seamonkey2.1a1?
(Assignee)

Comment 1

7 years ago
Created attachment 435877 [details] [diff] [review]
fork about.xhtml and make it take over about: with chrome privs

Here's my patch we can take if the global stuff doesn't work out as we'd like.

Comment 2

7 years ago
> +#expand <p id="version">&about.version; __MOZ_APP_VERSION__</p>

You know if we have chrome privileges we can just do:

document.getElementById("version"))
        .textContent ="&about.version; " + Application.version;

No need to pre-process the file.

Updated

7 years ago
Flags: blocking-seamonkey2.1a1? → blocking-seamonkey2.1a1+
(Assignee)

Comment 3

7 years ago
Philip, sure, we could look into that, but for now I copied what the global about.xhtml does, as the patch here is considered to be just a wallpaper over toolkit not getting things we need, I don't consider the patch a real solution to the problem. And as I still have a small amount of hope that toolkit might do something, this isn't even up for review, it's just here for potentially picking up later.
(Assignee)

Updated

7 years ago
blocking-seamonkey2.1: --- → a1+
Flags: blocking-seamonkey2.1a1+
(Assignee)

Comment 4

7 years ago
pushing off to a2, as bug 349985 is only waiting for sr right now.
blocking-seamonkey2.1: a1+ → a2+
(Assignee)

Updated

7 years ago
Target Milestone: seamonkey2.1a1 → seamonkey2.1a2
Comment on attachment 435877 [details] [diff] [review]
fork about.xhtml and make it take over about: with chrome privs

untested, but everything looks right. And I'd love to have this working in a2; but I'm ok with pushing off for a3 pending the about:* privs bug.
Attachment #435877 - Flags: review+
[now that we have an a3 flag, I'm happier pushing the blocking status off, but still would be good for a2]
blocking-seamonkey2.1: a2+ → a3+
(Assignee)

Updated

7 years ago
Target Milestone: seamonkey2.1a2 → seamonkey2.1a3
(Assignee)

Comment 7

7 years ago
Created attachment 460931 [details] [diff] [review]
v1.1.: updated patch for entity changes

This just updates for entity changes made on the toolkit version in bug 435550.

I'm now tired of waiting for the security sr from dveditz in the other bug, but requesting sr from Neil to make sure we don't load release notes with chrome privs when clicking the link, I hope he can confirm my assumption that we safely go back to normal content privs when following such a link there.

I'm also thinking about things we could do with this about: tab that possibly deviate from the general toolkit file anyhow, so there might be more than the original reason in the future to have this override in place.
Attachment #435877 - Attachment is obsolete: true
Attachment #460931 - Flags: superreview?(neil)
Attachment #460931 - Flags: review+

Updated

7 years ago
Attachment #460931 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 8

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/fa58a55a530b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

7 years ago
I forgot to package the new file, fixed that up in http://hg.mozilla.org/comm-central/rev/ab62e1205358
You need to log in before you can comment on or make changes to this bug.