555950 - Menu items black on XP and FavIcons black on Win7/Vista

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

On Win7 clicking on the Bookmarks from the MenuBar and dragging the mouse cursor downward the Favicons turn black as the list is moused over. 

Those in the Build Forum on Mozillazine using XP are reporting that the MenuBar items themselves are black. 

http://forums.mozillazine.org/viewtopic.php?p=9050305#p9050305

Regression range: 
Looks like the possible regression range is:
Good http://hg.mozilla.org/mozilla-central/rev/b9a743393b9c
Bad http://hg.mozilla.org/mozilla-central/rev/26be64ca9977

There were 2-3 failed builds between those two and I suspect that the checkin's by Rob is the culprit:
http://hg.mozilla.org/mozilla-central/rev/e70cb4e0921a 554764
http://hg.mozilla.org/mozilla-central/rev/28b6958c2372 555198
http://hg.mozilla.org/mozilla-central/rev/f3569af989e8 555133

Comment 1

[WildcatRay]

Link to image showing the issue:

http://img532.imageshack.us/img532/533/blacktoolbars.png

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

MenuBar also turns Black when using the Chatzilla Addon, the menubar in Chatzilla is black.

Comment 4

[Soumya Mallick]

The bug appears even when opened in safe mode with a new profile

Comment 5

[u88484]

Attachment: Black favicons background on Windows 7

Comment 6

[WildcatRay]

Attachment: Black menu and bookmark toolbars

Black menu and bookmark toolbars on WinXP.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: File menu

What my file menu looks like on Win7.

I'm using the Strata40 theme and Stratabuddy, but I don't think they do anything to Firefox's original menubar aside from glassing the menu headers.

Comment 8

[Tomasz Lipski]

Same thing happened to the Shredder nightly:
Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.3a4pre) Gecko/20100330 Lightning/1.1a1pre Shredder/3.2a1pre - Build ID: 20100330032408

Comment 9

[Tomasz Lipski]

Attachment: Black menubar and toolbar on Shredder

Comment 10

[[not reading bugmail]]

It seems using a lwtheme such as http://www.getpersonas.com/en-US/persona/20219 hides the problem.

Comment 12

[Masahiro YAMADA]

I can reproduce on Win XP,but I can not reproduce on Windows 2000SP4 Pro (Japanese edition, installed on Virtual PC) with "Windows Classic".

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a4pre) Gecko/20100330
Minefield/3.7a4pre

Comment 14

[[not reading bugmail]]

Attachment: black Download Window Search/Clear button status bar

Comment 15

[Benjamin Smedberg]

This blocks doing a devpreview release this week. rob/jimm, can one of you take this to back out whichever set of patches is necessary from the regression range identified in comment 0?

Comment 16

[Rob Arnold [:robarnold]]

Because I spent a lot of time in the past week or so dealing with the aero glass firedrill, I need to focus on my research for the next few days so I won't be able to help too much if you intend to have this fixed by Friday.

That said, I think http://hg.mozilla.org/mozilla-central/rev/f3569af989e8 is the likely culprit and in particular, isBackgroundPartiallyTransparent may be lying to us about toolbars/menus. Second guess is http://hg.mozilla.org/mozilla-central/rev/28b6958c2372 but unlikely since this affects toolbars too.

Comment 17

[Jim Mathies [:jimm]]

Attachment: icon oddities

Comment 19

[Jim Jeffery not reading bug-mail 1/2/11]

Using the lastest hourly based on cset:
http://hg.mozilla.org/mozilla-central/rev/3776e9061c1d
with the backout of suspect bug 555133 has fixed the Black FavIcon problem, also seems to fix the missing tool-tips when dw/d2d is on, still waiting for someone on XP to confirm that its fixed. 

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100331 Minefield/3.7a4pre ID:20100331113605

Comment 21

[[not reading bugmail]]

XP looks fine with latest hourly from cset after the backout:
http://hg.mozilla.org/mozilla-central/rev/c6e18218ed8e

Comment 22

[Marcel Kneuer]

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100331 Lightning/1.1a1pre Shredder/3.2a1pre ID:20100331032430: Menubar still black.

Comment 23

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to comment #22)
> Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100331
> Lightning/1.1a1pre Shredder/3.2a1pre ID:20100331032430: Menubar still black.

Is that the nightly build ?  If so, then the patch is not in that build, as it was fixed after the nightly came out.  You can either grab an hourly, or wait for tomorrows nightly and report back.

Comment 24

[[not reading bugmail]]

(In reply to comment #14)
> Created an attachment (id=436124) [details]
> black Download Window Search/Clear button status bar

My black downloads bar was still there.. but my profile had been in use quite a long time.  I just created a new profile and now its transparent glass on Win7 after the backout.

Comment 26

[u88484]

Using the latest hourly with the backout of bug 555133, pretty much everything that was blacked out was fixed except for the download manager :/

Comment 27

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to comment #26)
> Using the latest hourly with the backout of bug 555133, pretty much everything
> that was blacked out was fixed except for the download manager :/

Kurt, did you try a new profile ad Dals did in comment #24  ?  I don't have any black bars in the DM.

Comment 28

[Sebastian Podjasek]

After latest update my menu is back to normal in Thunderbird (devel)...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100401 Shredder/3.2a1pre

Comment 29

[Jim Jeffery not reading bug-mail 1/2/11]

Resolving this as fixed by backout of 555133.

Comment 30

[[not reading bugmail]]

(In reply to comment #24)
> (In reply to comment #14)
> > Created an attachment (id=436124) [details] [details]
> > black Download Window Search/Clear button status bar
> 
> My black downloads bar was still there.. but my profile had been in use quite a
> long time.  I just created a new profile and now its transparent glass on Win7
> after the backout.

I just noticed on a new profile, my D2D and DW has been off.. I turned it back on and the Download Window bar is still black like Kurt.  I wonder if that is just a separate bug altogether because I didn't notice it till the bug(s) in question landed.

Comment 31

[u88484]

Marking this verified fixed due to the backout of bug 555133.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100401 Minefield/3.7a4pre

(In reply to comment #30)
> (In reply to comment #24)
> > (In reply to comment #14)
> > > Created an attachment (id=436124) [details] [details] [details]
> > > black Download Window Search/Clear button status bar
> > 
> > My black downloads bar was still there.. but my profile had been in use quite a
> > long time.  I just created a new profile and now its transparent glass on Win7
> > after the backout.
> 
> I just noticed on a new profile, my D2D and DW has been off.. I turned it back
> on and the Download Window bar is still black like Kurt.  I wonder if that is
> just a separate bug altogether because I didn't notice it till the bug(s) in
> question landed.
Bug 556537