556046 - vertical line on tab thumbnails on about:home

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100330 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100330 Namoroka/3.7a4pre Fennec/1.1a2pre

Steps to Reproduce:
1. Go to about:home
2. Open the tab sidebar and view the thumbnail

Actual Results:
There's a gray colored vertical line on the right-center portion of the thumbnail

Expected Results:
I shouldn't see a gray colored vertical line

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This looks like a platform bug, refreshing the page once make the vertical line lighter and refreshing again make it gone!

I've dump some values from renderRectToCanvas for this and each time the values are identical.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: workaround

This is a workaround for this bug.

This "line" is not related to our usual linux bug for this type of lines (bug  468496) because it has been confirmed that this is also seen on Mac OSX.

Comment 4

[Martijn Wargers (dead)]

And I can also see the issue on windows.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 441836 [details] [diff] [review]
workaround

I've open bug 562337 as a platform bug for this particular case.

So, i think we should take the workaround while 562337 is not fixed.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 441836 [details] [diff] [review]
workaround

I think we do the same workaround here:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/TileManager.js.in#808

for bug 534054

Is bug 556046 really a dupe of bug 534054?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Oops bug 556046 is this bug

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien, I wonder if we should "+ 1" for the height as well. I am guessing that the thumbnail is smaller than a single tile (for height) and that is why we don't see horizontal lines. But maybe we should apply the same workaround for height.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This seems do to the work reasonably even if the UI is fullscreen on desktop.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/ac90676a2807

pushed m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/ba1a4aa2835a

Comment 11

[Aakash Desai [:aakashd]]

veirfied FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100429 Namoroka/3.6.5pre Fennec/1.1b2pre