Closed Bug 556076 Opened 14 years ago Closed 14 years ago

Textareas built dynamically do not get spellchecked in Fennec

Categories

(Core :: Layout: Text and Fonts, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jmaher, Assigned: crowderbt)

References

Details

Attachments

(2 files)

currently the tests/layout/reftests/bugs/300691-*.html tests fail if we have the layout.spellcheckDefault=1 due to the squiggly red line.

Instead of just changing the pref for the tests, we should have 1 set of tests to test with the spell check line and another set of tests to test without it.
Component: Reftest → Layout: Text
Product: Testing → Core
QA Contact: reftest → layout.fonts-and-text
Another suggestion would be adding spellcheck="false" to the <textarea>s in the tests. I don't think the red squiggles are required for the tests. I could be wrong though.
so I tried the spellcheck="false" method and the tests fail on desktop builds.
I was wrong, I didn't apply the spellcheck="false" to the reference image, only the test images.  This passes just fine when doing that.

A simple way to test both scenarios is to create a duplicate set of tests that have the spellcheck="false" defined and for the case when the pref is set, we can fail-if() one half of the tests.
Assignee: nobody → crowderbt
Sounds like you guys have some good options for handling this issue. Just in case, I am attaching a patch that would add support for --setpref to runreftests.py in mozilla-192
This is just a diff of the changes I made to add --setpref support to runreftests.py on mozilla-192
Attachment #437392 - Attachment description: diff → diff for --setpref support
we have setpref by default from addCommonOptions, we just need to adjust the test runners to use this
Looking at these tests, this is a horrible way to test the spellchecker and definitely -not- the intent of the tests themselves.  Let's just turn it off for these tests.

(sr? bz since the tests appear to have been created by him)
Attachment #437407 - Flags: superreview?(bzbarsky)
Attachment #437407 - Flags: review?(mark.finkle)
Attachment #437407 - Flags: review?(mark.finkle) → review+
Comment on attachment 437407 [details] [diff] [review]
disable spellcheck in these textareas

I'm ok with disabling the spellchecker for these tests, since the tests are not supposed to test spellcheck.

Boris - let us know if this change is not desired.

Crowder - I think we should file a separate bug for Fennec to figure out why the spellchecker is not executed (no red squiggles) when text is dynamically added.
Blocks: 557707
No longer blocks: 557707
Comment on attachment 437407 [details] [diff] [review]
disable spellcheck in these textareas

This seems fine as a workaround, but isn't the real bug that business about the spellchecker not running?  Once that gets fixed, this should be backed out, imo.
Attachment #437407 - Flags: superreview?(bzbarsky) → superreview+
Alright, well, if that's what we feel the "Right Fix" is, I'll dupe bug 557707 to this one and fix it here.
Summary: spellcheck causes reftest to fail, add new tests to cover both code paths → Textareas built dynamically do not get spellchecked in Fennec
It would be nice to know what landing fixed this, if someone in QA has time to bisect in m-c (or perhaps a landing in mobile-browser corrected it??)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: