556196 - [D2D] Jagged Back button

Status: RESOLVED DUPLICATE of bug 567295

(Core :: Graphics, defect)

Description

[[not reading bugmail]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100330 Minefield/3.7a4pre (.NET CLR 3.5.30729)
Build Identifier: 

with Direct2D enabled - Jagged Back Button in Windows 7.

Reproducible: Always



Expected Results:  
No Jagged Back button

See bug 554662 comment 20.

Comment 1

[[not reading bugmail]]

Attachment: Jagged Back Button

Comment 2

[Bas Schouten (:bas.schouten)]

I suspect this is a dupe of bug 554874.

Comment 4

[[not reading bugmail]]

The problem goes away now the backout for bug 555133 occurred.

Comment 5

[[not reading bugmail]]

(In reply to comment #4)
> The problem goes away now the backout for bug 555133 occurred.

I just noticed on a new profile, my D2D and DW has been off.. I turned it back using current hourly and the problem is still there.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

This is happening for me too

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100403 Firefox/3.7a3

Comment 7

[Shawn Wilsher :sdwilsh]

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100405 Minefield/3.7a4pre

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

the small icons on the toolbar do not exhibit this issue.

Comment 9

[RNicoletto]

(In reply to comment #8)
> the small icons on the toolbar do not exhibit this issue.

Confirmed! With small icons back button rendering is correct.

Comment 10

[hjalte]

Same jaggedness here in latest nightly build.  The forward button also seems to have a square around the arrow glyph that is less opaque than the rest of the button.  This is very noticeable when using a dark persona (not so much otherwise) and happens whether or not small icons are turned on.

Comment 11

[Josh Tumath]

I think I've figured out why this is happening. Is the button made circular using border-radius? If so, anti-aliasing doesn't seem to work when a CSS gradient is used. It could be another reason, however.

I noticed this on this website:
http://gyakusheets.houjun.com/

Comment 13

[bogas04]

Bug 563132

Since a weeks (time when 3.7a4 was entering last stages of RTW), i m seeing
that if i update my nightly , then i get very ugly shadows (without Anti
Aliasing i would say) on the Large Back button. But if i turn to small buttons,
then its fine

Further , a fresh install also fixes the problem. Then i used MozBackup and
restored everything but "General Settings" , it was normal, but on enabling
General Setting , the problem reappears. Now its almost impossible to know
which setting it was , also 3.6s , 3.5s and even 2.0s never gave this problem
so most probably there is some problem with new theme code.

And im not alone , see this mozilla.link page http://tinyurl.com/3axs7qm
There also , they got similar ugly shadows. 

Im adding my screenshot , showing the same.

https://bug563132.bugzilla.mozilla.org/attachment.cgi?id=442892

Comment 14

[Mathieu B]

I have this bug in one of my two win7/minefield-d2d PC :

win7 x64+Nvidia 8800GTS (driver 197.45)

but not on the other :

Win7 x86+Intel GMA950

On the first one, the first appearance of the bug is after I use a persona.

Comment 15

[Bas Schouten (:bas.schouten)]

(In reply to comment #14)
> I have this bug in one of my two win7/minefield-d2d PC :
> 
> win7 x64+Nvidia 8800GTS (driver 197.45)
> 
> but not on the other :
> 
> Win7 x86+Intel GMA950
> 
> On the first one, the first appearance of the bug is after I use a persona.

The second one might very well not be enabling Direct2D because of Intel GMA950 being too low spec.

Comment 16

[Mathieu B]

I have understand that DirectWrite cannot work without  Direct2D, but, in the GMA950 PC, directwrite is enabled (the difference with the fonts is clearly visible)

Comment 17

[Bas Schouten (:bas.schouten)]

(In reply to comment #16)
> I have understand that DirectWrite cannot work without  Direct2D, but, in the
> GMA950 PC, directwrite is enabled (the difference with the fonts is clearly
> visible)

Direct2D cannot work without DirectWrite (i.e. disabling DirectWrite will disable Direct2D). This is -not- true vice versa. DirectWrite -will- work without Direct2D.

Comment 18

[[not reading bugmail]]

Dao: The shadow effect looks better now with bug 555388 fixed, but its still jagged in its normal state and round in its pressed state which makes me wonder if there is still a tweak needed/fallout from bug 554662.

Comment 19

[[not reading bugmail]]

Something I see is odd.  The shadow effect looks like a cause of different back buttons.  The jaggedness still exists.

Open a new tab
look at disabled back button, same as attachment 436122 [details]
Navigate to a new page.
Navigate to a another new page and the back button changes style.
Back button is still jagged, the shadow effect is better.

Comment 20

[Bas Schouten (:bas.schouten)]

I've looked into this, the jaggedness is because the button's outline is 'shaped' by a circular clip. At the moment because of bug 556581 we cannot enable anti-aliased clipping without getting artifacts (this is bug 543729).

Comment 21

[RNicoletto]

(In reply to comment #20)
> I've looked into this, the jaggedness is because the button's outline is
> 'shaped' by a circular clip. At the moment because of bug 556581 we cannot
> enable anti-aliased clipping without getting artifacts (this is bug 543729).

Should we add dependencies to those bugs?

Comment 22

[Joe Drew (not getting mail)]

I don't think we've made a commitment to D2D blocking the 1.9.3 release, so this can't block either.