Closed Bug 556376 Opened 11 years ago Closed 11 years ago

Provide a common head for Places xpcshell-tests

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a4

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file, 1 obsolete file)

Unify common tools into a single head files, and stop being lazy.
Attached patch patch v1.0 (obsolete) — Splinter Review
As discussed on IRC, i don't think these tests changes are going to need deep review.  This one is the basic infrastructure, next ones would just be cleanups and var/svc replacements.

The idea here is that we have a head_common.js script in toolkit/components/places/tests/ all the other head_xxx.js files import this common head, and then define specific methods/vars for that specific test folder.
browser tests head also import this file.

head_common.js has Services, XPCOMUTils, NetUtil, a PlacesServices object with lazy getters for our services, and some utils.
in future we'll probably add PlacesUtils and PlacesUIUtils getters, and other common code.

I tried to scope all of the possible, so that variables conflicts are hard.

Will trypush all changes before going to m-c
Attachment #436366 - Flags: feedback?(dietrich)
Blocks: 529821
tryserver said green
hm, i'm actually thinking if would make sense to kill PlacesServices, add missing getters to PlacesUtils, and use PlacesUtils everywhere instead. Would create better examples for third party implementers looking at tests.
yeah. i'll do that, and will ask review for PU changes.
Attached patch patch v1.1Splinter Review
Using PlacesUtils!

asking review on PlacesUtils changes and head_common.js setup
other changes are merely name substitutions for now.
Attachment #436366 - Attachment is obsolete: true
Attachment #436554 - Flags: review?
Attachment #436366 - Flags: feedback?(dietrich)
Attachment #436554 - Flags: review? → review?(dietrich)
Comment on attachment 436554 [details] [diff] [review]
patch v1.1

looks good, thanks for doing this. r=me.
Attachment #436554 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/mozilla-central/rev/fb6fa1f88790
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Blocks: 556721
You need to log in before you can comment on or make changes to this bug.