Closed
Bug 556403
Opened 15 years ago
Closed 15 years ago
Move adding/removing of CCs into Bugzilla::Bug::set_all
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
|
5.06 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
This should be relatively straightforward, since we already have a whole setup in process_bug.cgi for add_cc and remove_cc.
|
Assignee | |
Comment 1•15 years ago
|
||
process_bug was allowing masscc and newcc to be set multiple times, which didn't make any sense, since they're never set multiple times. So I changed that. Otherwise, this is a pretty straightforward port.
I also did a bit of refactoring inside of set_all to remove the duplicate code pattern that I kept writing for add/remove stuff.
|
||
Comment 2•15 years ago
|
||
Comment on attachment 436343 [details] [diff] [review]
v1
Looks cleaner and all paths work as expected. r=dkl
Attachment #436343 -
Flags: review?(dkl) → review+
|
|
||
Updated•15 years ago
|
Flags: approval?
|
|
Assignee | |
Updated•15 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified process_bug.cgi
modified Bugzilla/Bug.pm
Committed revision 7192.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 4•14 years ago
|
||
(In reply to comment #1)
> process_bug was allowing masscc and newcc to be set multiple times, which
> didn't make any sense, since they're never set multiple times.
Sure you can, when CC'ing several users at once, Bugzilla::User::match_field() returns an arrayref.
You need to log in
before you can comment on or make changes to this bug.
Description
•