556418 - [k] Clicking through the paginator on search results keeps appending new pages to the URL

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[James Socol [:jsocol, :james]]

If I click through several pages of search results via the paginator, I end up with:

https://support-stage-new.mozilla.com/k/en/search?q=install&page=124&page=118&page=1&page=6

We need to make sure it replaces, not appends, new page values.

Comment 1

[Paul Craciunoiu [:paulc]]

What's the preferred approach here? I'm assuming any of these involves changing the behavior of |urlparams. Would it be better to:
* whitelist multivalued params, overwrite the rest by default
* blacklist single valued params, i.e. specify the ones to overwrite, and append to the rest by default
* something else?

Comment 2

[James Socol [:jsocol, :james]]

Just overwrite this one instead of appending. I assume this happens in the paginator, not |urlparams.

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #2)
> Just overwrite this one instead of appending. I assume this happens in the
> paginator, not |urlparams.
Yes.
r? at http://github.com/pcraciunoiu/kitsune/commit/6fb956119ee179c4c12dfdd1a1bebd57f7dd8ba1

Comment 4

[Paul Craciunoiu [:paulc]]

(In reply to comment #3)
> Yes.
> r? at
> http://github.com/pcraciunoiu/kitsune/commit/6fb956119ee179c4c12dfdd1a1bebd57f7dd8ba1
Oops. Make that http://github.com/pcraciunoiu/kitsune/commit/3703344e240fcdc0fa65c95f2cf01844dadd14c9

Comment 5

[Paul Craciunoiu [:paulc]]

Added test. 
http://github.com/pcraciunoiu/kitsune/commit/4aa84fc0b79128d62c9fa13682c390ecb4a505d2

Comment 6

[James Socol [:jsocol, :james]]

r+. Squash the test with the code and merge away.

Comment 7

[Paul Craciunoiu [:paulc]]

Squashed and merged and pushed.
http://github.com/jsocol/kitsune/commit/d4acd8d9b86f9f2c0bd10d24d960e5810ec95516

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

Now just retain and update a single page #, on URLs such as https://support-stage-new.mozilla.com/k/en-us/search?q=install&page=9, when clicking through the pages.