55659 - about:licence

Status: VERIFIED WORKSFORME

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Help|About Mozilla
2. Click on "MPL"

Actual result:
Page fetched from www.mozilla.org displayed

Expected result:
MPL displayed, but no network hit.

Additional comments:
It might be a legal requirement to ship the licence, even with tarballs.

Comment 1

[Ben Bucksch (:BenB)]

Fixed in my N6.0 tree

Comment 2

[Ben Bucksch (:BenB)]

Getting schizophrenic: Moving all bugs for Beonex <http://www.beonex.com> to my
second Bugzilla identity <[e-mail]>.

Comment 3

[Ben Bucksch (:BenB)]

I will attach a patch. It will include the fix for bug 55660. Developed on
Linux. IIRC, it compiled on Windows, not tested on Mac.

gagan, please r= or tell someone to do so.

Comment 4

[Ben Bucksch (:BenB)]

Created attachment 22600 [details] [diff] [review]
Fix, version 1

Comment 5

[Ben Bucksch (:BenB)]

export POSIXLY_CORRECT=1
cvs diff -uN netwerk/build/nsNetModule.cpp
netwerk/protocol/about/src/Makefile.in netwerk/protocol/about/src/makefile.win
netwerk/protocol/about/src/nsAboutWelcome.cpp
netwerk/protocol/about/src/nsAboutWelcome.h
netwerk/protocol/about/src/nsAboutLicense.cpp
netwerk/protocol/about/src/nsAboutLicense.h xpfe/communicator/jar.mn
xpfe/communicator/resources/locale/en-US/MANIFEST
xpfe/communicator/resources/locale/en-US/welcome.html xpfe/global/jar.mn
xpfe/global/resources/locale/en-US/license.html
xpfe/communicator/resources/locale/en-US/Makefile.in
xpfe/communicator/resources/locale/en-US/makefile.win
xpfe/global/resources/locale/en-US/makefile.win
xpfe/global/resources/locale/en-US/Makefile.in 
xpfe/global/resources/locale/en-US/MANIFEST > 55659-1.diff

Comment 6

[Gagan]

Ben: I don't think this should be done as separate files. All the about:foo that 
only redirect to another URL should be grouped together. And in the NewChannel 
we should check for the different cases and present the corresponding URL for 
it.

Comment 7

[Ben Bucksch (:BenB)]

gagan, I completely agree and thought of something similar. But this is another
bug (there are already 5 or so of these classes and I add only 2), which I don't
cannot/don't want to fix right now, and these bugs are fixed already and needed
for Beonex Comm..

Comment 8

[Gagan]

I disagree. The 5/6 classes you refer to all do different things. The case in 
point (and about:welcome) only deals with the ones that are "redirected" to 
another location. And so these cases should just be extensions to the way 
about:credits works. What is beonex comm...?

Comment 9

[Ben Bucksch (:BenB)]

Ok, it's just 3, not 5, existing classes which just redirect:
- <about:>
- <about:credits>
- <about:mozilla>
Still...

> What is beonex comm...?

A product based on Mozilla. <http://www.beonex.com/communicator>

Comment 10

[Jesse Ruderman]

If anyone files a bug on making the about: redirects share more code, please 
make that bug block bug 66607 (about:privacy).

Comment 11

[Ben Bucksch (:BenB)]

Gagan, I don't see the big difference problem if we have 3 or 5 classes which
essentiall do that same. If you block this bug, all you achieve is that you
force me to keep local changes (-> hassles with patch and new files, conflicts
during merges etc.).

Comment 12

[Gagan]

The difference is not just the additional classes which mean more memory space 
but also the extra files added for no benefit at all. And I can assure you the 
purpose of denying this checkin is not to make things difficult for you, but to 
make it better for the browser. Submit a patch that incorporates my suggestions 
of handling redirect cases in one class and then I'll review it. 

Comment 13

[Ben Bucksch (:BenB)]

Nobody reviewd so far :-(, so I have to move to Mozilla 0.9. Please review!

Comment 14

[Ben Bucksch (:BenB)]

> extra files added for no benefit at all

They sure have benefit for Beonex. How much code is in Mozilla that serves only
Netscape?

> Submit a patch that incorporates my suggestions

I have no time for such archtectural enhancements, at least not in the near
future. Actually, I wouldn't even know how to do it. I tried something like that
for about:<developer> back in 1999, IIRC, but gave up.

> Nobody reviewd so far :-(, so I have to move to Mozilla 0.9. Please review!

Ignore that - mass comment.

Comment 15

[Ben Bucksch (:BenB)]

I filed bug 68086 for the generic redirector class.

Comment 16

[Ben Bucksch (:BenB)]

Gagan, how about |#ifdef|ing the code? This would remove the footprint from the
standard distro and avoid patches and cvs conflicts on my side.

Comment 17

[benc]

mass move, v2.
qa to me.

Comment 18

[Michael Gabriel]

bug 68086 is fixed, can this be done easily now ?

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

note, by now such a redirector does exist (nsAboutRedirector.cpp)

Comment 20

[benc]

ben: can you clarify what the status is since bug 68086 is fixed?

If that works, shouldn't you just be able to hook up about: URLs to anything you
want?

Comment 21

[Ben Bucksch (:BenB)]

This bug is fixed as far as Beonex Communicator is concerned, thanks in part to
gagan's work on bug 68086.

However, I think this is a good idea for Mozilla as well. It is arguable. It
leave it to the netlib module owners to decide, if this should be fixed (in
which case I can contribute the simple fix) or be WONTFIXed.

Comment 22

[Gábor Stefanik]

Isn't this fixed long ago? About:licence now results in a British English MPL, while about:license produces an American English MPL. Marking WFM.

Comment 23

[Ben Bucksch (:BenB)]

Are you kidding? There is no British English MPL. about:licence shows a license which spells "license" American. Nobody expected otherwise.

This bug was about shipping the license with the app, not spelling. I think that has been fixed long ago indeed, but can't verify right now.

Comment 24

[benc]

V/wfm:

Seamonkey 1.1,2/macos.

Create new profile.
Go offline.
Go to about:license

OBSERVED:
viewed a license. Did not extensively check contents, but it looks like what was requested.