Closed Bug 556650 Opened 12 years ago Closed 12 years ago

Choose Language button on Facebook hard to read

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aakashd, Assigned: mbrubeck)

References

Details

(Keywords: polish, testcase, Whiteboard: rc1.1)

Attachments

(2 files)

Build id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100401 Namoroka/3.6.3pre Fennec/1.1a2pre


Steps to Reproduce:
1. Go to http://m.facebook.com/firefoxformobile
2. Pan down to the Language section and view the "Choose Language" button

Actual Results:
The text is in white and is very hard to read against a light-gray button
This is due to our use of background-image: linear-gradient in CSS. Web pages that try to change a button color using background-color will fail.
Is there a fix for this that doesn't mean we have to stop styling buttons this way?
Ah, sorry, I should have added more context. The problem types on reporter.mozilla.org are only ported over to Desktop Firefox problem types on the Broken Website Reporter. We're updating the website to relate the problem types under Fennec with those on Reporter for Fennec.

In this case, "Plugin Not Shown" is the located 3rd from the top on Desktop Firefox. For Reporter for Fennec, its "Buttons/Links".
Attached file testcase
I'm seeing this problem on quite a few sites.
Keywords: testcase
Keywords: polish
Using a transparent background gradient instead of a solid one would mitigate this quite a bit.
Attached patch patchSplinter Review
This patch replaces all rgb() values in background gradients with rgba values at 0.5 transparancy, calculated to give the same output when applied to a white background.

This should preserve our desired look by default, but degrade better in the presence of content-supplied background-color styles.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #445370 - Flags: review?(mark.finkle)
Whiteboard: rc1.1
Comment on attachment 445370 [details] [diff] [review]
patch

results are good. let's get on trunk and test.
Attachment #445370 - Flags: review?(mark.finkle) → review+
pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/ef9054a8b48e

baking on m-b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 566476
Looks great on trunk so far:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100518 Namoroka/3.7a5pre Fennec/2.0a1pre


I'm adding the tag need-1.1-ver to the whiteboard to verify this later on 1.1
Whiteboard: rc1.1 → rc1.1, [need-1.1-ver]
Whiteboard: rc1.1, [need-1.1-ver] → rc1.1
Retested bug with:
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111014 Firefox/10.0a1 Fennec/10.0a1
Device: Motorola Droid 2
OS: Android 2.3

Bug is no longer reproducible. Marking bug as verified.
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.