556748 - SMS Default Alarm Is Not Honored

Status: RESOLVED DUPLICATE of bug 493389

(Calendar :: Provider: GData, enhancement)

Description

[Josh Feingold]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 (.NET CLR 3.5.30729)
Build Identifier: Thunderbird/3.0.4 Lightning/1.0b1  Provider/.6b1

I am running Thunderbird with the Lightning and Provider Extensions on Windows 7.  Here are the exact versions:

Thunderbird/3.0.4
Lightning/1.0b1 
Provider/.6b1

I have successfully synced Lightning with my Gmail Calendar.  When I set the event in Gmail the default Alert is SMS, and this is noted via the phone icon in Lightning.

However, when I create the event in Lightning, it does not use the SMS Default event in Google, rather does a basic pop-up.  

Looking at the change-log for this version of provider it reads "bug 389088 - Use default alarms defined in Google Calendar, or add support for SMS alarms" which implies that the default event (which in my case is SMS) should be honored.  

Is there a setting that I need to set?  Am I missing something here?  How do I get the SMS Default to be honored, when I create new events?

Thanks
Josh

Reproducible: Always

Steps to Reproduce:
1. Create event in Lightning and use default event settings.
2. Open Gmail to view event.
3. Event is showing with a Pop-Up, which is not the default, rather SMS.
Actual Results:  
Event is showing with a Pop-Up alarm, which is not the default, rather SMS.

Expected Results:  
Event is showing with a SMS alarm.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

> However, when I create the event in Lightning, it does not use the SMS Default
> event in Google, rather does a basic pop-up.  
The Google Default reminder is in no way related with the Lightning default reminders.

> Looking at the change-log for this version of provider it reads "bug 389088 -
> Use default alarms defined in Google Calendar, or add support for SMS alarms"
> which implies that the default event (which in my case is SMS) should be
> honored.  
The bug description says *or*. support for SMS alarms was added, but its still not possible to use the default alarms.

You can try the custom alarms extension, but you will still need to choose an alarm from the dropdown: https://addons.mozilla.org/en-US/thunderbird/addon/97408/

I'm confirming this bug, we might be able to provide a checkbox to use the google defaults for events on gdata calendars. I'm pretty sure we already have a bug for this though (I can't find it).

Comment 2

[Josh Feingold]

Phillip -

Thanks for the reply.  Just so I understand, is there no way in Lightning to specify that the default alarm for a new event created in Lightning is a SMS message (which is how I want to get all of my alerts)?  

Thanks,
Josh

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

No, this is currently not possible.

Comment 4

[Josh Feingold]

Thanks. How do I put it up as a feature request, then?

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

No action required. We'll just use this bug :-)

Comment 6

[ian wood]

I think it's not specific to google calendar, its more about what a calendar web service should be able to achieve - defaults set in other calendar services would ideally be able to be used in Lightning also. 

I'm not sure if default alarms are part of the CalDav specification, but if so, it'd be good if Lightning had the option of using the server defaults, irrespective if Lighning is able to find out what they actually are (eg: gCal apparently fail in this respect).

In this sense, I'd suggest adding a dependency to Bug 357663 - Per calendar settings (e.g. default alarm)

Comment 7

[Jonathan]

Hi,

I don't know how I should submit these changes to fix this bug but I've made the following changes and this enables you to set the default alarm action in your about:config editor.

I've only tested this on Windows 7, Thunderbird 24.1.1 using Google as the provider.

I don't know how I could check for the provider being used and setting the capabilities accordingly?

Hope this is of interest.

Jonathan



lightning.js

lines 39-49:

// default alarm settings for new event
pref("calendar.alarms.onforevents", 0);
pref("calendar.alarms.eventalarmlen", 15);
pref("calendar.alarms.eventalarmunit", "minutes");
pref("calendar.alarms.eventalarmaction", "SMS"); //Can be DISPLAY,SMS or EMAIL

// default alarm settings for new task
pref("calendar.alarms.onfortodos", 0);
pref("calendar.alarms.todoalarmlen", 15);
pref("calendar.alarms.todoalarmunit", "minutes");
pref("calendar.alarms.todoalarmaction", "SMS"); //Can be DISPLAY,SMS or EMAIL


calAlarmUtils.jsm

lines 38-47:

// Get alarm actionPref
let actionPref = cal.getPrefSafe("calendar.alarms." + type + "alarmaction", "DISPLAY");

// Default to a display alarm, unless the calendar doesn't support
// it or we have no calendar yet. (Man this is hard to wrap)
let actionValues = ((aItem.calendar && aItem.calendar.getProperty("capabilities.alarms.actionValues")) || ["DISPLAY"]);

alarm.action = actionValues[actionValues.indexOf(actionPref)];


calWcapCalendar.js

lines 133-134:

case "capabilities.alarms.actionValues":
  return ["DISPLAY", "EMAIL", "SMS"];

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

I will take a look at this. The usual format is to create a patch based on the repository at hg.mozilla.org/comm-central/

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

As the main use case for this is the provider for Google Calendar and the new version of the provider in bug 493389 will be able to handle default alarms, I don't think we should use a hidden pref here.