556767 - (semantics) Improve/Complete implementation of <semantics/>

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

This is a meta-bug to track issues related to <semantics/>.

Currently, we use CSS to display only the first child.
We should probably write a class nsMathMLsemanticsFrame to have a better control on what should be displayed or not.
Also, this should probably help having the same behavior as other frames and hence fixing bugs.

Comment 1

[Frédéric Wang (:fredw)]

I've just tried to implement a NS_NewMathMLsemanticsFrame and it allows to fix bug 468059, bug 512418, bug 523037 and bug 523045. I'll attach a patch when I've made reftests from their testcases.

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Patch

This patch fixes the four bugs mentioned above as well as the special case of bug 21479 related to <semantics/>.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

In bug 468059 comment 1 you suggested just creating an nsMathMLContainerFrame. Did that not work? Why did you create a new frame type here?

Comment 4

[Frédéric Wang (:fredw)]

Actually, I haven't tried to directly use a NS_NewMathMLContainerFrame. I just need nsMathMLsemanticsFrame to get embellished-op data from the first child in TransmitAutomaticData(). Although I can implement a function TransmitAutomaticData in NewMathMLContainerFrame that does this job when mContent->Tag() == semantics_, I find it cleaner to work in a separate class. Also, this class could be useful if one improves the behavior of the <semantics/> element:

http://mxr.mozilla.org/mozilla-central/source/layout/mathml/mathml.css#414

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 443701 [details] [diff] [review]
Patch

That makes sense.

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/23f53ef7a5b4