Last Comment Bug 572899 - Reftest mathml/semantics-1.xhtml fails with STIX 1.0.0
: Reftest mathml/semantics-1.xhtml fails with STIX 1.0.0
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla14
Assigned To: Frédéric Wang (:fredw)
:
Mentors:
Depends on:
Blocks: semantics downloaded-stretchy
  Show dependency treegraph
 
Reported: 2010-06-17 16:25 PDT by Zack Weinberg (:zwol)
Modified: 2012-05-20 20:00 PDT (History)
6 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
rendering of test (4.90 KB, image/png)
2010-06-17 16:27 PDT, Zack Weinberg (:zwol)
no flags Details
rendering of reference (4.85 KB, image/png)
2010-06-17 16:29 PDT, Zack Weinberg (:zwol)
no flags Details
Patch V1 (1.63 KB, patch)
2012-03-31 10:28 PDT, Frédéric Wang (:fredw)
karlt: review+
zackw: feedback+
Details | Diff | Review

Description Zack Weinberg (:zwol) 2010-06-17 16:25:42 PDT
The reftest mathml/semantics-1.xhtml has just started failing for me - some things are being drawn slightly lower on the screen in the presence of <semantics> tags than they are without.  I will attach screen shots, it's hard to describe.

This worked a week ago, is (apparently) not failing on the build farm, and the only system change that appears to be relevant is that my Linux distributor has just picked up the 1.0.0 release of the STIX fonts, so I'm provisionally blaming that.
Comment 1 Zack Weinberg (:zwol) 2010-06-17 16:27:20 PDT
Created attachment 452128 [details]
rendering of test
Comment 2 Zack Weinberg (:zwol) 2010-06-17 16:29:18 PDT
Created attachment 452130 [details]
rendering of reference

The most obvious difference between these screenshots is that the first left-justified row of black and white boxes is slightly farther away from its overline in the test than in the reference, but if you flip back and forth between them, other things move too.  (I freehanded the area to grab, so the top and left margins may not match.  That's not the problem I'm talking about.)
Comment 3 Zack Weinberg (:zwol) 2010-06-17 16:30:11 PDT
By the way, is this test _supposed_ to draw checkerboard rows, or does that indicate some other problem?
Comment 4 Frédéric Wang (:fredw) 2010-06-29 14:07:56 PDT
No, the checkerboard is not a problem. FYI, the purpose of these tests is to check that

1) semantics does not prevent displaystyle to be inherited (i.e. mtext children of munderover are drawn as under/over scripts not sub/sup scripts). 
2) semantics does not prevent displaystyle the transmission of embellishement data (i.e. the bar stretches).
3) the semantics does not produce extra spaces around it.
4 & 5) the semantics does not interfere with maction (i.e. the selected child of maction should be 3 and 4 respectively)

Apparently, the difference is only with tests 1) and 2) on your screenshot. I've only the problem with test 2). It seems that spaces are added around semantics frame but I can not explain how STIX 1.0 could be involved. Trying to force margin, border, padding to 0 for semantics does not seem to be helpful.
Comment 5 Frédéric Wang (:fredw) 2012-03-31 10:28:08 PDT
Created attachment 611174 [details] [diff] [review]
Patch V1

Replacing the <mtext> by an <mspace> seems to work better for me. Does that fix the problem for you too?
Comment 6 Zack Weinberg (:zwol) 2012-03-31 16:18:58 PDT
Comment on attachment 611174 [details] [diff] [review]
Patch V1

Yes, that fixes it for me too.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-04-03 17:10:31 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/047ca959dceb
Comment 8 Marco Bonardo [::mak] 2012-04-04 05:04:26 PDT
https://hg.mozilla.org/mozilla-central/rev/047ca959dceb

Note You need to log in before you can comment on or make changes to this bug.