Port Firefox bookmarks tests to SeaMonkey

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Trunk
seamonkey2.1a3
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Once bug 498596 switches us to places bookmarks, we also should get tests for those, starting porting the Firefox tests over to SeaMonkey.
(Assignee)

Comment 1

7 years ago
Created attachment 458244 [details] [diff] [review]
add those tests that succeed

This patch adds all the tests that succeed, I spent too many hours trying to make others work, esp. in the browser-chrome area, and I gave up on them for now.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #458244 - Flags: review?(neil)
Comment on attachment 458244 [details] [diff] [review]
add those tests that succeed

rs+ based on a skim... but

>+++ b/suite/common/places/tree.xml
>-            for (let j = min.value; j <= max.value; ++j)
>-              nodes.push(resultview.nodeForTreeIndex(j));
>+            if (max.value > -1)
>+              for (let j = min.value; j <= max.value; ++j)
>+                nodes.push(resultview.nodeForTreeIndex(j));

Was this another patches remnant, or needed for a test here, if so can you please explain it for posterity.

(If I find time to actually review the tests, I may steal review from neil; but I would think my rs+ is ok for the test-only changes, especially if they all pass.)
Attachment #458244 - Flags: review+
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> Was this another patches remnant, or needed for a test here, if so can you
> please explain it for posterity.

Thanks for catching that, it's indeed a remnant, though from testing why some of the not added tests failed. It's not wrong, but it probably doesn't belong there.
(Assignee)

Updated

7 years ago
Blocks: 498596
No longer depends on: 498596
(Assignee)

Updated

7 years ago
Attachment #458244 - Flags: review?(neil)
(Assignee)

Comment 4

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/b9e980d6f85d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Version: unspecified → Trunk

Updated

7 years ago
Blocks: 505121

Updated

7 years ago
No longer blocks: 505121
(In reply to comment #3)
> It's not wrong, but it probably doesn't belong there.

This |if (max.value > -1)| got pushed anyway.
Should we revert it (ftb)?
Or try to add it to Firefox too?
Flags: in-testsuite+
Blocks: 632860
Blocks: 725529
You need to log in before you can comment on or make changes to this bug.