557808 - OOPP crash notification bar doesn't show for small plugins

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Axel Hecht [:Pike]]

On http://flashcrash.dempsky.org/ with a userContent.css of

@-moz-document domain(flashcrash.dempsky.org) {
   embed {
     width: 1px !important;
     height: 1px !important;
   }

} 

I don't see the notification bar for a crashed plugin.

Fehler: [Exception... "'JavaScript component does not have a method named: "observe"' when calling method: [nsIObserver::observe]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]

is the last error in the error console.

Reading the last two messages on http://groups.google.com/group/mozilla.dev.l10n/browse_frm/thread/05b4bf36bbb4f6cc#, that's a regression on lorentz.

Tested on a lorentz nightly from the 6th.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Benjamin suspects a bad merge!

Comment 2

[Justin Dolske [:Dolske]]

Are you sure that was a Lorentz nightly from the 6th? That specific error was fixed by one of the patches in bug 554214, which landed on 3/24. I suspect your nightly wasn't up to date.

However, a current 1.9.2 (post-Lorentz-merge) still fails to show the notification bar, albeit with a different error. After fixing that, it works fine for me. Patch coming next.

Comment 3

[Axel Hecht [:Pike]]

oops, I guess I unpacked the wrong build. I'll wait with more tests 'til your patch lands.

Comment 4

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 5

[Justin Dolske [:Dolske]]

Looks like this happened because this conditional was added by bug 553371, and the patch for bug 544936 landed right after, and didn't change this instance of |minidumpID|.

Comment 6

[Justin Dolske [:Dolske]]

Note that this is broken on trunk too!

Comment 7

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/f9bbdcfe2d1b
Pushed to 192: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c7c0e410f7e7

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Verified fixed in build 1 of 1.9.2.4.