557824 - move default configs for android into configure.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

The goal here is to keep the mozconfig as simple as possible, pushed to the working repo:

http://hg.mozilla.org/users/vladimir_mozilla.com/mozilla-droid/rev/a771e2afb8b8
http://hg.mozilla.org/users/vladimir_mozilla.com/mozilla-droid/rev/db1c5588a421

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 437582 [details] [diff] [review]
patch

Why are we dropping the alt choice in the --disable- args with this patch?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

the defaults are being set between lines 4900 and 5000, so the effect is the same if you don't pass a the flag. But this allows us to override the defaults on a per-platform basis.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 437582 [details] [diff] [review]
patch

>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>+MOZ_CRASHREPORTER=1

This isn't right, crashreporter is defaulted on only for supported platforms. You shouldn't need to touch the crashreporter bits, since it shouldn't be trying to build on Android anyway.

>+dnl ========================================================
>+dnl Use ARM userspace kernel helpers; tell NSPR to enable
>+dnl their usage and use them in spidermonkey.
>+dnl ========================================================
>+MOZ_ARG_WITH_BOOL(arm-kuser,
>+[  --with-arm-kuser         Use kuser helpers (Linux/ARM only -- requires kernel 2.6.13 or later)],
>+    USE_ARM_KUSER=1,)
>+if test -n "$USE_ARM_KUSER"; then
>+   AC_DEFINE(USE_ARM_KUSER)
>+fi
>+

Move this block down below the --enable-application stuff, maybe right before "toolkit options"?

r=me with those changes.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch w/nits

things changed a bit since you reviewed this so I'd like you to take a second look. The functional change is to enable ogg, wave, faststripe, thumb2, jemalloc and tree freetype by default for android.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/21f0727c27a6