745998 - Port |Bug 739132 - --disable-necko-wifi causes "Error: package error or possible missing or unnecessary file: bin/components/necko_wifi.xpt"| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Serge Gautherie (:sgautherie)]

SM 2.10 and 2.9:
I won't bother fixing that, unless someone actually complains about this bug.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Add configure support for NECKO_WIFI, Use it for SeaMonkey packaging [Checked in: See comment 2+5+6 & 7 & 8+9]

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 615522 [details] [diff] [review]
(Av1) Add configure support for NECKO_WIFI, Use it for SeaMonkey packaging
[Checked in: See comment 2+5+6 & 7 & 8+9]

http://hg.mozilla.org/comm-central/rev/769ffdc41a52


[Approval Request Comment]
No risk.

Comment 3

[Mark Banner (:standard8)]

Backed this out due to complete all-platform build bustage, please remember to watch all trees you can affect especially for the short time after pushing for changes like this.

https://hg.mozilla.org/comm-central/rev/28dc4ceee019

checking for sys/int_types.h... (cached) no
/builds/slave/tb-comm-cen-lnx/build/configure: line 17818: syntax error near unexpected token `iwlib.h'
/builds/slave/tb-comm-cen-lnx/build/configure: line 17818: `  MOZ_CHECK_HEADER(iwlib.h)'
*** Fix above errors and then restart with               "make -f client.mk build"
make[2]: *** [configure] Error 1
make[2]: Leaving directory `/builds/slave/tb-comm-cen-lnx/build'
make[1]: *** [objdir-tb/config.status] Error 2
make[1]: Leaving directory `/builds/slave/tb-comm-cen-lnx/build'
make: *** [build] Error 2
program finished with exit code 2

Comment 4

[Misak Khachatryan]

MOZ_CHECK_HEADER(iwlib.h)'

Removing/commenting out this line makes build successful.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 615522 [details] [diff] [review]
(Av1) Add configure support for NECKO_WIFI, Use it for SeaMonkey packaging
[Checked in: See comment 2+5+6 & 7 & 8+9]

http://hg.mozilla.org/comm-central/rev/207aa287be44
(Bv1) s/MOZ_CHECK_HEADER/AC_CHECK_HEADER/.
+
http://hg.mozilla.org/comm-central/rev/6dcf542bcc36
Merge of bug 745998.

Succeeded as
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=11204cc7189b


(In reply to Mark Banner (:standard8) from comment #3)
> Backed this out due to complete all-platform build bustage, please remember
> to watch all trees you can affect especially for the short time after
> pushing for changes like this.

Sorry about that (and forgetting to Try it in the first place). I usually do.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 615522 [details] [diff] [review]
(Av1) Add configure support for NECKO_WIFI, Use it for SeaMonkey packaging
[Checked in: See comment 2+5+6 & 7 & 8+9]

http://hg.mozilla.org/comm-central/rev/530a1afbf7f4
(Cv1) Unbackout the 2 other files too.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/comm-aurora/rev/f74e6f31fc6e

Comment 8

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-beta/rev/13a71e741a05

Comment 9

[Mark Banner (:standard8)]

I just had to push a bustage fix for this:

https://hg.mozilla.org/releases/comm-beta/rev/c26790d2d108

This was the transplant of the previous bustage fix.

When requesting approval, please ensure your patch is the combined non-busted version and also be explicit about what changesets peoples should transplant if they are transplanting.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 615522 [details] [diff] [review]
(Av1) Add configure support for NECKO_WIFI, Use it for SeaMonkey packaging
[Checked in: See comment 2+5+6 & 7 & 8+9]

(In reply to Mark Banner (:standard8) from comment #9)
> be explicit about what changesets peoples should transplant if they are transplanting.

I think I am! In this case, I had not (yet) requested c-n to beta...

Comment 11

[Mark Banner (:standard8)]

(In reply to Serge Gautherie (:sgautherie) from comment #10)
> I think I am! In this case, I had not (yet) requested c-n to beta...

The main issue was the patch you requested approval on was not correct for beta. Neither the aurora or beta approval requests mentioned about the fact the patch wasn't correct.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to Mark Banner (:standard8) from comment #11)
> The main issue was the patch you requested approval on was not correct for
> beta.

My point of view is that the "main" issue is that patches I want to land are stuck on approval requests while patches I haven't asked to land get pushed (out of order) :-<
I understand what you write but I can't accept blame for what other people (= Callek in this case) do on their own.