User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100407 Firefox/3.6 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100407 Minefield/3.7a5pre Toolbar buttons that have a drop-down menu no longer work. Only the drop-down component is accessible -- even when the button itself is clicked. Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f292d7bd2e93&tochange=a1d1e59ac1de Reproducible: Always Steps to Reproduce: 1. Install "Reload Every" extension: http://reloadevery.mozdev.org/#installation 2. After restarting Minefield, notice that whenever you click the refresh button, it is only the button's drop-down menu that works. 3. Reproducible also with the following extensions: a) Video DownloadHelper: https://addons.mozilla.org/en-US/firefox/addon/3006 b) Print Preview: https://addons.mozilla.org/en-US/firefox/addon/1778
Yes, toolbarbutton with type="menu-button"does not work properly.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Created attachment 437763 [details] [diff] [review] fix Thanks for catching that. originalLength was to be used to check if new elements were added, not to list the local list of frames.
Attachment #437763 - Flags: review?(roc)
Attachment #437763 - Flags: review?(roc) → review+
We need a mochitest here to catch this regression.
(In reply to comment #3) > We need a mochitest here to catch this regression. I hope the fix can still land without the test being already there, though, as functionality is broken right now...
Affects the Flashblock toolbar button as well. See: <https://www.mozdev.org/bugs/show_bug.cgi?id=22698>
Yes, the fix can land as-is.
Created attachment 437952 [details] [diff] [review] fix with tests Merged the fix here, with tests included in this patch. For the tests, it's not possible to get anonymous nodes from elementFromPoint, so what I did is to dispatch mouseclicks on the toolbarbutton and make sure that the button and the menu dropmarker correctly receive the events. roc, does this seem reasonable for the test? I verified and it does catch the regression if the fix is not applied. Also included in the test a check for <menulist editable="true"/> (reported as bug 558162) which is the same bug.
Attachment #437952 - Flags: review?(roc)
Attachment #437952 - Flags: review?(roc) → review+
(anyone interested feel free to land and I can watch the tree)
Is there anyone monitoring this bug, who could land this? Thanks.
Created attachment 438269 [details] [diff] [review] fix with tests - for checkin turns out the button inside menubuttons have a rounded style on mac and dispatching a click on the edge is not ideal. I made a minor change in this version to send the click to the center. Sent to tryserver, everything ran green.
Assignee: nobody → felipc
Attachment #437952 - Attachment is obsolete: true
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Verifying fixed using an hourly build with the cset: http://hg.mozilla.org/mozilla-central/rev/aa360768a319 Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre ID:20100410132025
Status: RESOLVED → VERIFIED
(In reply to comment #14) > Verifying fixed using an hourly build with the cset: Patch seems not solve the bug in 'Modern Theme' from SM. Right-clicking on that Icons in 'Modern' don't show a menue. It always choose the default of this button. Please set 'Status' to 'REOPENED'
(In reply to comment #15) > (In reply to comment #14) > > Verifying fixed using an hourly build with the cset: > > Patch seems not solve the bug in 'Modern Theme' from SM. Right-clicking on that > Icons in 'Modern' don't show a menue. It always choose the default of this > button. > > Please set 'Status' to 'REOPENED' I'm not sure that it is the same bug, since this one was tracking a specific regression. Can you file a new bug and CC me on it, and I'll help investigate. If it is indeed the same bug I'll mark it as duplicate and reopen this.
You need to log in before you can comment on or make changes to this bug.