558201 - The resizer in RTL textareas shows an incorrect cursor

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[(no longer active)]

When you hover the resizer icon for RTL textareas, the cursor should be NESW, however it's currently NWSE.

Comment 1

[Neil Deakin]

Is this Mac specific?

Comment 2

[(no longer active)]

No.  I also tested it on Linux and Windows.

On Linux, something very strange happens.  The resizer icon doesn't even appear in RTL mode, but when I move the cursor to the lower right corner (which is where the LTR resizer icon should be), the cursor appears in NWSE form (the wrong form.)

On Windows, the cursor appears in NWSE form, just like on Mac and Linux.

Comment 3

[Neil Deakin]

This is likely caused because the cursor is set in resizer.css as:

resizer[dir="bottomend"]:-moz-locale-dir(rtl) {
  cursor: sw-resize;
}

There isn't a way to set the cursor property because the direction property is rtl though, right?

The only way I see to fix this is to add an nsResizerFrame::GetCursor implementation.

Comment 4

[(no longer active)]

(In reply to comment #3)
> This is likely caused because the cursor is set in resizer.css as:
> 
> resizer[dir="bottomend"]:-moz-locale-dir(rtl) {
>   cursor: sw-resize;
> }
> 
> There isn't a way to set the cursor property because the direction property is
> rtl though, right?

AFAIK, no.  And :-moz-locale-dir doesn't work because we're in an HTML document.

> The only way I see to fix this is to add an nsResizerFrame::GetCursor
> implementation.

How about we provide a fallback implementation in resizer.xml to detect if we're inside an HTML document (actually, to detect if we're not inside a XUL document) and set a direction attribute based on the direction computed style, so that we can use that in CSS to set the correct cursor?

Comment 5

[(no longer active)]

Please note that Simon marked the reftest as random because of what I observed in comment 2.

http://hg.mozilla.org/mozilla-central/diff/201589e94d3b/layout/reftests/forms/reftest.list

This needs to be reverted when the fix for this bug lands.

Comment 6

[Neil Deakin]

Fixed by bug 554810.

Comment 7

[Jesse Ruderman]

> http://hg.mozilla.org/mozilla-central/diff/201589e94d3b/layout/reftests/forms/reftest.list
> 
> This needs to be reverted when the fix for this bug lands.

http://hg.mozilla.org/mozilla-central/rev/328ec01e7119

(This was forgotten until my script noticed it.)