558252 - Add the Camino Hg repo to MXR

Status: RESOLVED FIXED

(Webtools Graveyard :: MXR, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We need MXR to index the new Camino hg repo, http://hg.mozilla.org/camino/

"Starting Points" (http://mxr.mozilla.org/) Name:
Camino

"Starting Points" description: 
This is this the source code of the Camino browser.

Initial checkout command is: 
hg clone http://hg.mozilla.org/camino/ $camino_or_destination_of_choice

Update command is standard (where pwd = $camino_or_destination_of_choice):
hg pull -u

Please let me know if you need any additional information.

Comment 1

[timeless]

Attachment: pending push

Reed: this does the right thing (including bootstrapping).

I won't push it until someone from somewhere agrees that they want this added (I'm pretty sure we do).

smokey: congrats and welcome to hg :)

Comment 2

[Reed Loden [:reed]]

Comment on attachment 438074 [details] [diff] [review]
pending push

>+          This is this the source code of the <a
>+href="http://caminobrowser.org/">Camino browser</a>.

"This is this the" ? Also might want to mention "for Mac" or something... dunno.

>+    /^(?:(?:.*)-(?:central|tracing)|camino)$/ && do {

Is camino the only weird non -central one here, or could we go ahead and add support for others, too?

>+        unless (-d "$src_dir/.hg") {

You could probably get away with |-d "$src_dir"| here, but I like the .hg check, so fine.

>+          my $dir = basename($src_dir);
>+          print LOG `$TIME $HGCOMMAND $HGCLONE https://hg.mozilla.org/$dir $src_dir`;
>+        }
>         print LOG `cd $src_dir; $TIME $HGCOMMAND $HGUPDATE $STDERRTOSTDOUT`;

Seems like you're doing some useless work by doing an update immediately after cloning... you could just do if/else or unless/else if you wanted, but I don't particularly care.

r=me with the html issue fixed... the rest are your call.

Comment 3

[timeless]

http://hg.mozilla.org/webtools/mxr/rev/505ae7c12ab0

someone will have to add cron scripts as usual

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> http://hg.mozilla.org/webtools/mxr/rev/505ae7c12ab0

Thanks timeless!

> someone will have to add cron scripts as usual

How does that work?  Do I need to file a bug somewhere to make that happen, or?