Closed
Bug 558302
Opened 14 years ago
Closed 14 years ago
[HTML5][Patch] <button> should not be scoping
Categories
(Core :: DOM: HTML Parser, defect, P2)
Tracking
()
VERIFIED
FIXED
People
(Reporter: Virtual, Assigned: hsivonen)
References
()
Details
(Keywords: nightly-community)
Attachments
(1 file)
9.71 KB,
patch
|
mozilla+ben
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.9.3a5pre) Gecko/20100408 Minefield/3.7a5pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100408 Minefield/3.7a5pre Just compere with html5 enabled and disabled. Also with html5 all links cant be clicked (except only this upper menu) and searchbar is rendered on wrong place Reproducible: Always Steps to Reproduce: 1. enable HTML5 (about:config => html5.enable=true) 2. go to http://www.gf-hunters.de/ Actual Results: Wrongly rendered site Expected Results: Properly rendered site with clickable working links
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•14 years ago
|
Version: unspecified → Trunk
Comment 1•14 years ago
|
||
That pref just controls the parser; it has nothing to do with layout. Henri, can you please take a look? It looks like the relevant part of the markup is: <button type="submit" id="searchsubmit" value="" /> </form> which is an unclosed button; this causes all the rest of the web page to be inside the button with the HTML5 parser. I presume the </form> closes the button in the old parser?
Status: UNCONFIRMED → NEW
Component: Layout → HTML: Parser
Ever confirmed: true
QA Contact: layout → parser
Comment 2•14 years ago
|
||
This markup works in Safari and Opera too, so probably needs a spec change to support it.
Comment 3•14 years ago
|
||
Though I can't figure out _why_ it works in opera.... Maybe it lets links inside buttons be clickable? Certainly live dom viewer claims the links are inside the button.
Blocks: html5-parsing
Summary: enabled HTML5 causing site to renderer wrong without clickable links → [HTML5] enabled HTML5 causing site to renderer wrong without clickable links
Assignee | ||
Comment 4•14 years ago
|
||
Looks like <button> should not be a scoping element. I wonder why it is per spec. Furthermore, </form> should pop stuff more aggressively when the element pointed to by the form pointer is in scope.
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #4) > Looks like <button> should not be a scoping element. I wonder why it is per > spec. > > Furthermore, </form> should pop stuff more aggressively when the element > pointed to by the form pointer is in scope. It's sufficient to make <button> non-scoping. Changing how </form> is handled is not necessary. Filed a spec bug: http://www.w3.org/Bugs/Public/show_bug.cgi?id=9496
Priority: -- → P2
Assignee | ||
Updated•14 years ago
|
Summary: [HTML5] enabled HTML5 causing site to renderer wrong without clickable links → [HTML5] <button> should not be scoping
Assignee | ||
Comment 6•14 years ago
|
||
The spec got changed: http://html5.org/tools/web-apps-tracker?from=5031&to=5032
Assignee | ||
Updated•14 years ago
|
Summary: [HTML5] <button> should not be scoping → [HTML5][Patch] <button> should not be scoping
Updated•14 years ago
|
Attachment #438722 -
Flags: review?(bnewman) → review+
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/739aec32e63e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Keywords: nightly-community
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•