558726 - |-moz-user-select = "none"| elements missing from innerHTML in latest Minefield

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Mathieu Pellerin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre

Within the last few days (sorry I can't get more precise that this ATM), a change in Minefield resulted in buggy innerHTML content: <select> and <input> elements are missing.

Reproducible: Always

Steps to Reproduce:
1. Open test case
2. Click on the 'display innerHTML' button
Actual Results:  
The alert box displays improper html content found within the <div id="template"> in which the <select> and <input> elements are missing

Expected Results:  
The alert box should display the proper html content found within the <div id="template">

Comment 1

[Mathieu Pellerin]

Attachment: test case

Comment 2

[Alice0775 White]

Attachment: testcase2

Regression window:

Works:
http://hg.mozilla.org/mozilla-central/rev/aa360768a319
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre ID:20100410132025

Fails:
http://hg.mozilla.org/mozilla-central/rev/1a6aac2558e4
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre ID:20100410154225

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=aa360768a319&tochange=1a6aac2558e4

Comment 3

[Alice0775 White]

When I backed out http://hg.mozilla.org/mozilla-central/rev/2b560e956063 from 3bcd237e52a6 in local build, the problem is gone.
So I presume Bug 166235 cause this problem.

Comment 4

[Alice0775 White]

This bug breaks the 'Show Code' button function on userstyles.org .

See http://forums.mozillazine.org/viewtopic.php?p=9148015#p9148015

Comment 5

[Mats Palmgren (inactive)]

Taking, since it's my fault really.  Geoff's "v2" patch in bug 166235
tested for 'mIsCopying', which makes it not affect innerHTML.
We have two options:
 1. backout and reopen bug 166235 to implement it correctly
    (in the Selection code).
 2. take the "v2" patch for now

2 is ok with me, roc?

Comment 6

[Mats Palmgren (inactive)]

Attachment: Geoff's "v2" version (diff -w)

Fixes this bug, but makes Selection.toString() different from what is copied.

Comment 7

[Mats Palmgren (inactive)]

Attachment: mochitest.diff

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 438645 [details] [diff] [review]
Geoff's "v2" version (diff -w)

We should have a test for this regression bug too

Comment 9

[Mats Palmgren (inactive)]

Attachment: Geoff's "v2" version (for checkin)

For landing when the tree opens, together with mochitest.diff

Comment 10

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/81c83a98798d
http://hg.mozilla.org/mozilla-central/rev/90861e26db38