55893 - race in zip cache code

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P3)

Description

[Warren Harris]

There is a race condition in the zip reader cache code that we hit quite often 
due to the fact that the zip cache is accessed on multiple threads. Jband has 
the fix. 

Spinoff of bug 53312.

Comment 1

[Warren Harris]

rtm+

Comment 2

[Phil Peterson]

PDT marking [rtm need info] since no patches or code reviewers are given. We'd
also like to understand the severity -- if it isn't a crasher, it's probably
[rtm-] at this point.

Comment 3

[John Bandhauer]

Attachment: proposed fix

Comment 4

[John Bandhauer]

The diff was off in bug 53312 (which predates this). I've attached it here too. 
Waiting for reviews from dprice and warren.

I suspect that this bug will rarely bite in the rtm version if we continue to 
set the cache limit at 32 jars. We only get that high if the user downloads lots 
of jars - the count of our shipped jars is low. This bug will only bite when 
kicking out jars from the cache.

Note that bug 53312 needs this change.

Comment 5

[Daniel Bratell]

This bug has had an attached patch for three weeks, but still no reviews by
dprice or warren. Maybe it should go rtm-.

Comment 6

[John Bandhauer]

This patch is a subset of the patch in bug 53312. Setting dependency.

Comment 7

[dprice (gone)]

fixed when 53312 was fixed

Comment 8

[dprice (gone)]

forgot to mark as fixed.