559005 - The last tab with 'about:blank' should have a close button, and hide it when CloseWithLastWindow is false

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[Alfred Kayser]

Now that bug 501714 is fixed (the last tab should have a close button), there now a special case to be considered:
When the last tab is 'empty' (when it is displaying 'about:blank') the close button should not be visible/active, as there is nothing to close.

Comment 1

[Alfred Kayser]

The logic should as follows:
if (only one tab is displayed, and it is empty (showing about:blank)) 
{
   if (closeWindowWithLastTab = true)
      show close button //as one can close the last tab, closing the whole window
   else
      hide close button //The last tab (when empty) can not be closed.
}

Compare with Chrome which has 'closeWindowWithLastTab' behaviour: the last tab always has a close button, and always close the window.

Compare with Opera which has 'closeWindowWithLastTab=false' behaviour: the last tab never has a close button, and never closes the window.

Using the following CSS I can simulate the desired behaviour:
/* With closeWindowWithLastTab=false, with only one tab, and empty, don't show close button */
.tabbrowser-tab[label="New Tab"]:first-of-type:last-of-type > .tab-close-button{
	display:none}
/* With closeWindowWithLastTab=true, with only one tab, and empty, do show close button (even if not empty) */
.tabbrowser-tabs[closebuttons="noclose"]>.tabbrowser-tab:first-of-type:last-of-type >.tab-close-button{
	display:-moz-box}

Comment 2

[Alfred Kayser]

Notes from bug 490166:
Replace :first-of-type:last-of-type with :only-of-type.
[label="New Tab"] is not good enough indeed. I need something else to test for 'empty page' status, this needs something in browser.js to indicate 'empty' status.

Comment 3

[Michael Kohler [:mkohler]]

Bug 501714 enables the close button on the last tab (empty) when closeWindowWithLastTab == false . This was done due to inconsistency problems between mouse and keyboard.

Now you want to disable the close button if closeWindowWithLastTab == false? I'm sorry, but this doesn't make any sense.

Maybe you need to explain your request a little bit further?

Comment 4

[Michael Kohler [:mkohler]]

Oh, forget about my last comment, misunderstood you. I'm sorry about that.