559764 - make <input type="range"> accessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

If it's going look like a slider then we could reuse accessible classes for XUL scale and XForms range.

Comment 1

[sfornengo]

what about render html5 input type=range as a slider ?
it seems nobody works on it although firefox is far behind the other browsers on smart rendering of html5 inputs.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> what about render html5 input type=range as a slider ?
> it seems nobody works on it although firefox is far behind the other
> browsers on smart rendering of html5 inputs.

You should put your comment into bug 344618 where the control is supposed to be implemented, this bug is about to make accessible (make it working with screen readers) what done in bug 344618.

Comment 3

[alexander :surkov (:asurkov)]

Note, input@type="range" got own face in bug 344618 in Firefox 22. It's time to take care about accessibility.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch

1) a slider role, no underlying indicator - an accessible for a thumb, not sure if anybody needs it, however note XUL:scale has it and MSAA requires it (http://msdn.microsoft.com/en-us/library/windows/desktop/dd373645%28v=vs.85%29.aspx)
2) implements value interface
3) fires value change event

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 739404 [details] [diff] [review]
patch

Not sure why you need Step() when there is GetStep().
I'd prefer having just GetStep

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 739404 [details] [diff] [review]
> patch
> 
> Not sure why you need Step() when there is GetStep().
> I'd prefer having just GetStep

it seems getters in this file aren't used to have Get prefix. GetStep is protected thus I added Step(). So should I make GetStep() public by moving it to public section?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

making it public sounds ok.
(I'm surprised it is protected now.)

Comment 8

[Trevor Saunders (:tbsaunde)]

Comment on attachment 739404 [details] [diff] [review]
patch

>+HTMLRangeAccessible::NativeRole()
>+{
>+  return roles::SLIDER;
>+}
>+
>+////////////////////////////////////////////////////////////////////////////////
>+// HTMLRangeAccessible<Max>: Widgets

s/<max>//

Comment 9

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b9554b2b1c

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6b9554b2b1c