Last Comment Bug 559764 - make <input type="range"> accessible
: make <input type="range"> accessible
Status: RESOLVED FIXED
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal with 4 votes (vote)
: mozilla23
Assigned To: alexander :surkov
:
:
Mentors:
http://dev.w3.org/html5/spec/forms.ht...
Depends on: 559753 344618
Blocks: html5a11y 2013q2a11y
  Show dependency treegraph
 
Reported: 2010-04-15 23:36 PDT by alexander :surkov
Modified: 2013-04-29 15:12 PDT (History)
9 users (show)
surkov.alexander: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (20.10 KB, patch)
2013-04-18 20:56 PDT, alexander :surkov
tbsaunde+mozbugs: review+
roc: review+
bugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2010-04-15 23:36:37 PDT
If it's going look like a slider then we could reuse accessible classes for XUL scale and XForms range.
Comment 1 sfornengo 2011-07-27 14:10:55 PDT
what about render html5 input type=range as a slider ?
it seems nobody works on it although firefox is far behind the other browsers on smart rendering of html5 inputs.
Comment 2 alexander :surkov 2011-07-27 19:52:58 PDT
(In reply to comment #1)
> what about render html5 input type=range as a slider ?
> it seems nobody works on it although firefox is far behind the other
> browsers on smart rendering of html5 inputs.

You should put your comment into bug 344618 where the control is supposed to be implemented, this bug is about to make accessible (make it working with screen readers) what done in bug 344618.
Comment 3 alexander :surkov 2013-03-26 18:50:10 PDT
Note, input@type="range" got own face in bug 344618 in Firefox 22. It's time to take care about accessibility.
Comment 4 alexander :surkov 2013-04-18 20:56:24 PDT
Created attachment 739404 [details] [diff] [review]
patch

1) a slider role, no underlying indicator - an accessible for a thumb, not sure if anybody needs it, however note XUL:scale has it and MSAA requires it (http://msdn.microsoft.com/en-us/library/windows/desktop/dd373645%28v=vs.85%29.aspx)
2) implements value interface
3) fires value change event
Comment 5 Olli Pettay [:smaug] (reviewing overload) 2013-04-19 05:35:32 PDT
Comment on attachment 739404 [details] [diff] [review]
patch

Not sure why you need Step() when there is GetStep().
I'd prefer having just GetStep
Comment 6 alexander :surkov 2013-04-19 06:12:45 PDT
(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 739404 [details] [diff] [review]
> patch
> 
> Not sure why you need Step() when there is GetStep().
> I'd prefer having just GetStep

it seems getters in this file aren't used to have Get prefix. GetStep is protected thus I added Step(). So should I make GetStep() public by moving it to public section?
Comment 7 Olli Pettay [:smaug] (reviewing overload) 2013-04-19 06:16:49 PDT
making it public sounds ok.
(I'm surprised it is protected now.)
Comment 8 Trevor Saunders (:tbsaunde) 2013-04-26 10:55:06 PDT
Comment on attachment 739404 [details] [diff] [review]
patch

>+HTMLRangeAccessible::NativeRole()
>+{
>+  return roles::SLIDER;
>+}
>+
>+////////////////////////////////////////////////////////////////////////////////
>+// HTMLRangeAccessible<Max>: Widgets

s/<max>//
Comment 10 Wes Kocher (:KWierso) 2013-04-29 15:12:01 PDT
https://hg.mozilla.org/mozilla-central/rev/f6b9554b2b1c

Note You need to log in before you can comment on or make changes to this bug.