make <input type="range"> accessible

RESOLVED FIXED in mozilla23

Status

()

Core
Disability Access APIs
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {access})

unspecified
mozilla23
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
If it's going look like a slider then we could reuse accessible classes for XUL scale and XForms range.

Comment 1

6 years ago
what about render html5 input type=range as a slider ?
it seems nobody works on it although firefox is far behind the other browsers on smart rendering of html5 inputs.
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> what about render html5 input type=range as a slider ?
> it seems nobody works on it although firefox is far behind the other
> browsers on smart rendering of html5 inputs.

You should put your comment into bug 344618 where the control is supposed to be implemented, this bug is about to make accessible (make it working with screen readers) what done in bug 344618.
(Assignee)

Comment 3

4 years ago
Note, input@type="range" got own face in bug 344618 in Firefox 22. It's time to take care about accessibility.
(Assignee)

Updated

4 years ago
Blocks: 855324
(Assignee)

Updated

4 years ago
Assignee: nobody → surkov.alexander
(Assignee)

Comment 4

4 years ago
Created attachment 739404 [details] [diff] [review]
patch

1) a slider role, no underlying indicator - an accessible for a thumb, not sure if anybody needs it, however note XUL:scale has it and MSAA requires it (http://msdn.microsoft.com/en-us/library/windows/desktop/dd373645%28v=vs.85%29.aspx)
2) implements value interface
3) fires value change event
Attachment #739404 - Flags: review?(trev.saunders)
Attachment #739404 - Flags: review?(roc)
Attachment #739404 - Flags: review?(bugs)
Attachment #739404 - Flags: review?(roc) → review+

Comment 5

4 years ago
Comment on attachment 739404 [details] [diff] [review]
patch

Not sure why you need Step() when there is GetStep().
I'd prefer having just GetStep
Attachment #739404 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

4 years ago
(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 739404 [details] [diff] [review]
> patch
> 
> Not sure why you need Step() when there is GetStep().
> I'd prefer having just GetStep

it seems getters in this file aren't used to have Get prefix. GetStep is protected thus I added Step(). So should I make GetStep() public by moving it to public section?

Comment 7

4 years ago
making it public sounds ok.
(I'm surprised it is protected now.)
Comment on attachment 739404 [details] [diff] [review]
patch

>+HTMLRangeAccessible::NativeRole()
>+{
>+  return roles::SLIDER;
>+}
>+
>+////////////////////////////////////////////////////////////////////////////////
>+// HTMLRangeAccessible<Max>: Widgets

s/<max>//
Attachment #739404 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 9

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b9554b2b1c
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/f6b9554b2b1c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.