559877 - Fix timeout in test_559800.js

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Comment 1

[Dave Townsend [:mossop]]

Shawn can you give me some suggestions here.

What is the effect of opening a connection to an database that is in the middle of being closed with asyncClose?

Comment 2

[Shawn Wilsher :sdwilsh]

Depends on how you open it (pragmas), but file locks can still exist on the file.

Comment 3

[Dave Townsend [:mossop]]

Here is what I appear to be seeing.

I close the database with asyncClose.
Without waiting I delete the database file.
Then I open the database again.

At this point I appear to have the old database as if it was never deleted. Does this match your expectations and is there any way to avoid it without needing to wait for the callback from asyncClose?

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> At this point I appear to have the old database as if it was never deleted.
> Does this match your expectations and is there any way to avoid it without
> needing to wait for the callback from asyncClose?
Yeah, I can see that happening very easy, and no, I can't think of a way to avoid that offhand.  If you opened it with an exclusive lock (suggested if you don't want other applications to modify it while you have it open) and disable the shared cache (which is only useful if you have more than one connection anyway), the call to open would fail until it closes.  You could come up with some way to poll based on that, but it's not a pretty solution.

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Looks like there isn't an easy way to do an exact test here, this instead simulates the problem by setting the DB schema in the prefs which is what we use to determine if the DB has been migrated before.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 440540 [details] [diff] [review]
patch rev 1

Is it possible to have a new test that sets everything up except for the database to test the original scenario where everything is there besides the database? If so, can you file a followup?

Comment 7

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/b9d66dffe46c

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This test doesn't fail anymore. Marking as verified fixed.