Closed Bug 559994 Opened 10 years ago Closed 10 years ago
Work items to enable versioning in AVM shell
To support bug compatibility, and to fix sundry bugs, we need to enable API versioning in AVM core code and in the VM shell generally. That means dealing with some work items we've put off: - API versioning is always enabled in the shell, the stuff in avmfeatures.as goes away. - Object.as (and any other AS file that uses versioning) must include api-versions.as, but that file currently lives in the flash player code, so we need to have a copy in the core code, and it should not be in the shell/ directory - The api-versions.as file should be generated by the apivergen.as script, probably - the version in flash is hand-hacked but there's no reason for it to be that. - We should pow-wow with the Flash people to agree on where the .xml input file and the .h and .as output files live, ie, whether the Flash player copies the stuff from Tamarin or vice versa. Some precedent for the former exists.
Does the following: - Removes the AVMFEATURE for shell versioning; we assume it's on. Cleans up the #includes for the various files - Removes noapi-versions.* from shell/ - Moves api-versions.* from shell/ to core/ - Adds api-versions.java in core/ because it's silly not to have it there - Makes apivergen.as generate api-versions.as - Makes apivergen.as compute the highest non-SYS version because the shell needs it to get default verioning right - Adds modelines to apivergen.as, and changes tabs to spaces (If the patch is big it's because I moved a bunch of files and fixed spaces/tabs in the apivergen.as script, not because these change were momentous.)
Attachment #440027 - Flags: review?(jodyer)
tamarin-redux changeset: 4544:29990aab21ef. Action item on interacting with the Player team moved to bug #560756.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.