560215 - maxattachmentsize = 0 means that you cannot attach any file to bugs

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[u115838]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: 3.6

If I try to attach any file I'm getting the error "The file you are trying to attach is 40 kilobytes (KB) in size. Non-patch attachments cannot be more than 0 KB."

According to docementation maxattachmentsize 0 means: "subject to the limitations of your server software"

If I change maxattachmentsize to 4000 I can attach the file.

Reproducible: Always

Steps to Reproduce:
1. set maxattachmentsize to 0
2. attach a file
3. 
Actual Results:  
error "The file you are trying to attach is 40 kilobytes (KB) in size. Non-patch attachments cannot be more than 0 KB."

Expected Results:  
the file will was attached

Comment 1

[Frédéric Buclin]

I'm going to reword the parameter description a bit to reflect what we do in the backend. If you set this parameter to 0, you won't be able to attach any file. "To accept attachments of any size" doesn't make sense. You never want to be able to attach a file of *any* size.

Comment 2

[Max Kanat-Alexander]

No, it's valid to want to be able to attach attachments of any size--I mean, at some point the backend will limit it, won't it?

Of course, I suppose some people might not want 4G attachments in their PostgreSQL database--I think that could be a DoS. So looking at it from that viewpoint, you're right.

Comment 3

[Frédéric Buclin]

You can set the parameter to allow 4 Gb attachments, if you are crazy enough. You just have to do it explicitly. For 3.8, I'm going to also hide the "Add an attachment" link in the attachment table when the param is 0, to not confuse users. For 3.6, I simply reword the param description.

Comment 4

[Max Kanat-Alexander]

Okay, although I don't think I've *ever* seen anybody request the ability to disable adding attachments--I wonder, would that just confuse people?

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Okay, although I don't think I've *ever* seen anybody request the ability to
> disable adding attachments--I wonder, would that just confuse people?

If the param is 0, the backend code doesn't let you add any attachment already. The front-end would now simply be consistent with what the backend code lets you do. It's not a new feature.

Comment 6

[Max Kanat-Alexander]

(In reply to comment #5)
> If the param is 0, the backend code doesn't let you add any attachment already.
> The front-end would now simply be consistent with what the backend code lets
> you do. It's not a new feature.

  Okay, that sounds reasonable.

Comment 7

[Frédéric Buclin]

Attachment: patch for tip, v1

Only backend code changes, besides a rewording of the param description. For 3.6, only the rewording of the param description applies. I won't alter the UI now that we are post-3.6.

Comment 8

[Max Kanat-Alexander]

Comment on attachment 439969 [details] [diff] [review]
patch for tip, v1

Looks great!

Comment 9

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/params/attachment.html.tmpl
modified template/en/default/attachment/list.html.tmpl
modified template/en/default/bug/create/create.html.tmpl
Committed revision 7129.


Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified template/en/default/admin/params/attachment.html.tmpl
Committed revision 7084.