560504 - JSAPI no longer compiles with Leopard's default compiler

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Wesley W. Garland]

The default compiler being "gcc version 4.0.1 (Apple Inc. build 5465)".  I believe this is XCode 3.01. Anyhow, it's what came on my Leopard DVD when I bought this mac.

What happen is that it refuses to build jsemit.o, with errors like this:
/Users/wes/hg/tracemonkey/js/src/jsemit.cpp:1239: error: ‘JSTreeContext’ has not been declared
/Users/wes/hg/tracemonkey/js/src/jsemit.cpp: In function ‘bool inStatement(JSStmtType)’:
/Users/wes/hg/tracemonkey/js/src/jsemit.cpp:1241: error: ‘topStmt’ was not declared in this scope

This bug was introduced very recently, I believe with change set 341ffe867ea8, Bug 558437  (although I haven't I been completely thorough in verifying that).

Jorendorff believes this is a compiler bug; not being a C++ guy I can't comment on that, but I think we should support this compiler if we can.

Comment 1

[Wesley W. Garland]

Attachment: Trivial patch to fix

This winds up being a two-colon fix

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 440194 [details] [diff] [review]
Trivial patch to fix

I agree with all that.

Comment 3

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/6deb7f5f7a71

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/6deb7f5f7a71