560715 - Windows trunk builds failing due to: storagecomps.dll : fatal error LNK1120: 2 unresolved externals

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Trunk builds of comm-central are failing with:

storage_s.lib(mozStorageAsyncStatementExecution.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class mozilla::TimeStamp __cdecl mozilla::TimeStamp::Now(void)" (__imp_?Now@TimeStamp@mozilla@@SA?AV12@XZ) referenced in function "private: unsigned int __thiscall mozilla::storage::AsyncExecuteStatements::buildAndNotifyResults(struct sqlite3_stmt *)" (?buildAndNotifyResults@AsyncExecuteStatements@storage@mozilla@@AAEIPAUsqlite3_stmt@@@Z)
storage_s.lib(mozStorageAsyncStatementExecution.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class mozilla::TimeDuration __cdecl mozilla::TimeDuration::FromMilliseconds(int)" (__imp_?FromMilliseconds@TimeDuration@mozilla@@SA?AV12@H@Z) referenced in function "private: __thiscall mozilla::storage::AsyncExecuteStatements::AsyncExecuteStatements(class nsTArray<class mozilla::storage::StatementData> &,class mozilla::storage::Connection *,class mozIStorageStatementCallback *)" (??0AsyncExecuteStatements@storage@mozilla@@AAE@AAV?$nsTArray@VStatementData@storage@mozilla@@@@PAVConnection@12@PAVmozIStorageStatementCallback@@@Z)
storagecomps.dll : fatal error LNK1120: 2 unresolved externals

Possibly as a result of bug 480735.

vlad took a look at a possible fix, but didn't get any improvement.

I'm confused why this isn't happening on the other platforms. I've therefore triggered a clobber of all the Windows check builders to see if that resolves it.

Comment 1

[Mark Banner (:standard8)]

Neil thinks this is because there are some missing dlldeps.cpp changes from an earlier bug - see bug 506959 comment 13.

If anyone can try and reproduce and test a fix, please do. Otherwise I'll have to take a look tomorrow.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It's not due to either of those bugs, but as commented, dlldeps.cpp is missing any reference to TimeStamp stuff at all -- so none of the TimeStamp methods are being exported.  The storage change to use TimeStamp is just exposing this.  (dlldeps seems incredibly fragile!)

Comment 3

[[e-mail]]

Attachment: Bustage fix [Checkin: See comment 4+7]

Comment 4

[Justin Wood (:Callek)]

(In reply to comment #3)
> Created an attachment (id=440437) [details]

Pushed as: http://hg.mozilla.org/mozilla-central/rev/8ff5e04c0566

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Oops, my regression.

Comment 6

[Justin Wood (:Callek)]

this patch did not actually fix the bug :/

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 440437 [details] [diff] [review]
Bustage fix
[Checkin: See comment 4+7]


http://hg.mozilla.org/mozilla-central/rev/ed54089cce34