Closed Bug 56098 Opened 24 years ago Closed 24 years ago

link coloring not working

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: tor, Assigned: attinasi)

References

Details

(Keywords: regression) 

Link color (ie <body link="#ff0000">) isn't working.  All links are
coming up bright blue.  Some sample URLs exhibiting this problem:

  http://www.opengl.org/
  http://www.bluesnews.com/
  http://slashdot.org/

Small testcase:

<body link="#ff0000">
<a href="foobar">test</a>
Forgot to mention this was tested on a linux build pulled about 6am pacific
time October 11th.

Regression caused by attinasi's checkin for bug 40340.
Assignee: pierre → attinasi
Keywords: regression
Priority: P3 → P1
*** Bug 56107 has been marked as a duplicate of this bug. ***
*** Bug 56111 has been marked as a duplicate of this bug. ***
I'd rather see bugs on the regression marked as dups of this bug rather than bug
40340 because I'd rather not see bug 40340 get too cluttered.
Accepting. I am fixing it right now.
Status: NEW → ASSIGNED
The fix is easy, and it was suggested by dbaron yesterday before I checked this
in but I didn't understand it at that time (see bug 40340).

The link rules, as checked in, were always !important. Important rules in the
backstop stylsheet will override non-important author rules, so the bug was thus
manifested.

As David suggested, the fix is to make the link rules non-important UNLESS we
are also overriding the document colors, in which case the link rules become
important. This makes Moz slightly different than Nav (Nav always allowed author
style rules to override the link colors, even if document colors were set to be
ignored) but I believe it is more correct because the option to 'always use my
colors, ignoring the colors in a document' is positioned in the pref UI such
that it seems like it will apply to link colors as well as text and background
colors.

Thanks David, sorry it took me a day to understand what you were suggesting.
I'll post the patch and update the trunk asap.

Fix checked in to trunk. r=karnaze, a=buster
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Target Milestone: --- → M19
*** Bug 56246 has been marked as a duplicate of this bug. ***
Verified fixed on 12/11 Linux build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.