Closed Bug 561016 Opened 10 years ago Closed 10 years ago

e10s: Add support for openURIInFrame in BrowserAccess

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
e10s adds openURIInFrame to nsIBrowserDOMWindow:
http://mxr.mozilla.org/projects-central/source/electrolysis/dom/interfaces/base/nsIBrowserDOMWindow.idl#113

This patch adds basic support to Fennec
Attachment #440691 - Flags: review?(webapps)
Note: We can land this on mobile-browser too. It won't hurt anything.
Comment on attachment 440691 [details] [diff] [review]
patch

We discussed refactoring this so that code isn't duplicated.
Attachment #440691 - Flags: review?(webapps)
Attached patch patch 2Splinter Review
Code duplication has been removed. Tested in e10s build and mobile-browser build.
Assignee: nobody → mark.finkle
Attachment #440691 - Attachment is obsolete: true
Attachment #441129 - Flags: review?
Comment on attachment 441129 [details] [diff] [review]
patch 2

This fixes Google News, yay :)
Attachment #441129 - Flags: review? → review+
Pushed http://hg.mozilla.org/users/pavlov_mozilla.com/mobile-e10s/rev/4011844bf771
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 516521
Attached patch patch for mobile-browser (obsolete) — Splinter Review
tested in mobile-browser
Attachment #445964 - Flags: review?(webapps)
Attachment #445964 - Flags: review?(webapps) → review+
Comment on attachment 445964 [details] [diff] [review]
patch for mobile-browser

>+  _getBrowserForOpen: function(aURI, aOpener, aWhere, aContext) {

Nit: not crazy about the name.  _getBrowser should be fine because of the context?  _getBrowserForOpenURI if you want to be specific?
_getBrowserForOpenURI -> _getBrowser
Attachment #445964 - Attachment is obsolete: true
Attachment #447146 - Flags: review+
Depends on: 570121
You need to log in before you can comment on or make changes to this bug.