561016 - e10s: Add support for openURIInFrame in BrowserAccess

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

e10s adds openURIInFrame to nsIBrowserDOMWindow:
http://mxr.mozilla.org/projects-central/source/electrolysis/dom/interfaces/base/nsIBrowserDOMWindow.idl#113

This patch adds basic support to Fennec

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Note: We can land this on mobile-browser too. It won't hurt anything.

Comment 2

[Benjamin Stover (:stechz)]

Comment on attachment 440691 [details] [diff] [review]
patch

We discussed refactoring this so that code isn't duplicated.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Code duplication has been removed. Tested in e10s build and mobile-browser build.

Comment 4

[Benjamin Stover (:stechz)]

Comment on attachment 441129 [details] [diff] [review]
patch 2

This fixes Google News, yay :)

Comment 5

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/users/pavlov_mozilla.com/mobile-e10s/rev/4011844bf771

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for mobile-browser

tested in mobile-browser

Comment 7

[Benjamin Stover (:stechz)]

Comment on attachment 445964 [details] [diff] [review]
patch for mobile-browser

>+  _getBrowserForOpen: function(aURI, aOpener, aWhere, aContext) {

Nit: not crazy about the name.  _getBrowser should be fine because of the context?  _getBrowserForOpenURI if you want to be specific?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for mobile-browser

_getBrowserForOpenURI -> _getBrowser

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/4cfb4164ba20