Closed
Bug 561016
Opened 14 years ago
Closed 14 years ago
e10s: Add support for openURIInFrame in BrowserAccess
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(2 files, 2 obsolete files)
4.60 KB,
patch
|
stechz
:
review+
|
Details | Diff | Splinter Review |
3.70 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
e10s adds openURIInFrame to nsIBrowserDOMWindow: http://mxr.mozilla.org/projects-central/source/electrolysis/dom/interfaces/base/nsIBrowserDOMWindow.idl#113 This patch adds basic support to Fennec
Attachment #440691 -
Flags: review?(webapps)
Assignee | ||
Comment 1•14 years ago
|
||
Note: We can land this on mobile-browser too. It won't hurt anything.
Comment 2•14 years ago
|
||
Comment on attachment 440691 [details] [diff] [review] patch We discussed refactoring this so that code isn't duplicated.
Attachment #440691 -
Flags: review?(webapps)
Assignee | ||
Comment 3•14 years ago
|
||
Code duplication has been removed. Tested in e10s build and mobile-browser build.
Assignee: nobody → mark.finkle
Attachment #440691 -
Attachment is obsolete: true
Attachment #441129 -
Flags: review?
Comment 4•14 years ago
|
||
Comment on attachment 441129 [details] [diff] [review] patch 2 This fixes Google News, yay :)
Attachment #441129 -
Flags: review? → review+
Comment 5•14 years ago
|
||
Pushed http://hg.mozilla.org/users/pavlov_mozilla.com/mobile-e10s/rev/4011844bf771
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•14 years ago
|
||
tested in mobile-browser
Attachment #445964 -
Flags: review?(webapps)
Updated•14 years ago
|
Attachment #445964 -
Flags: review?(webapps) → review+
Comment 7•14 years ago
|
||
Comment on attachment 445964 [details] [diff] [review] patch for mobile-browser >+ _getBrowserForOpen: function(aURI, aOpener, aWhere, aContext) { Nit: not crazy about the name. _getBrowser should be fine because of the context? _getBrowserForOpenURI if you want to be specific?
Assignee | ||
Comment 8•14 years ago
|
||
_getBrowserForOpenURI -> _getBrowser
Attachment #445964 -
Attachment is obsolete: true
Attachment #447146 -
Flags: review+
Assignee | ||
Comment 9•14 years ago
|
||
pushed to m-b: http://hg.mozilla.org/mobile-browser/rev/4cfb4164ba20
You need to log in
before you can comment on or make changes to this bug.
Description
•