561212 - [Promo module]Button extends to the next tab in French locale

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/z/fr/firefox/#t-social
2.Notice the left hand side of the promo module.

observed behavior:
see screenshot

Comment 1

[Craig Cook (:craigcook)]

This is tangentially related to bug 560590. The button text is simply too long and buttons aren't designed to wrap. Possible solutions, in my order of recommendation:

1. Devise a shorter equivalent translation for the button label (would need help from French localizers).

2. Rebuild buttons to allow wrapping text (related to bug 560590, still awaiting final decision).

3. Exclude EULA add-ons from the promo box since those add-ons have long buttons (just evades this specific problem without really solving it, and the buttons will still be superlong when they appear in other areas).

4. Hide the column overflow (this would truncate wide buttons and make them unreadable, probably a bad idea).

Comment 2

[Wil Clouser [:clouserw]]

Is there a way to hide the overflow for non "active" panes of the carousel?

Comment 3

[Craig Cook (:craigcook)]

(In reply to comment #2)
> Is there a way to hide the overflow for non "active" panes of the carousel?

That would prevent the offscreen button from jutting into the active viewing area, but when that pane is active itself the same button goes outside the viewing area and gets cut off. Whenever a button is wider than its column it invades the column next to it.

So just clipping or hiding the non-active panes doesn't actually solve the real problem. It's really down to either less text per button or buttons that allow the text to wrap.

Comment 4

[Wil Clouser [:clouserw]]

CCing Alexandre.  I think this is caused by this button label:

Continuer vers les téléchargements →

How can we make this shorter?

Comment 5

[:gerard-majax]

If it's length, we might try something like « Aller aux téléchargements ». I just commited a change to z-messages.po to do this, r66475.

Comment 6

[Wil Clouser [:clouserw]]

I think that works, thanks.  Further discussion for these buttons is happening in the last comments of bug 560590

Comment 7

[:gerard-majax]

Okay, let me know if you need any other changes

Comment 8

[krupa raj[:krupa]]

This looks much better now.Thanks!