561535 - Quickfilter non-functional if the Welcome page appears on run (e.g. after an update)

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Mozilla/5.0 (X11; U; Linux i686; lt; rv:1.9.2.5pre) Gecko/20100423 Lanikai/3.1b2pre

Instead of focusing the quick search bar, Ctrl+F opens the in-message search bar.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

It's supposed to toggle between them.  If your focus is not in the quick filter bar text filter, it should focus the quick filter bar text filter.  If your focus is in the quick filter bar text filter, it should focus the in-message search bar.

Is this not what you are seeing?

Comment 2

[Rimas Kudelis [use needinfo to ping]]

Nope, it doesn't toggle. Just opens the in-message search or selects all text in it's input box if it already has focus.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

QA peeps, can you magic this some?

We actually have mozmill tests for this case, so I am presuming there are some extenuating circumstances not immediately obvious to me.

Comment 4

[Wayne Mery (:wsmwk)]

WFM on vista, today's nightly

Comment 5

[Thomas D. (:thomas8)]

WFM on WinXP trunk, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100423 Shredder/3.2a1pre

Comment 6

[Ludovic Hirlimann [:Usul]]

Rimas can you try in -safe-mode ?

Comment 7

[Rimas Kudelis [use needinfo to ping]]

Wow!
Not only does it work in safe mode, but it ALSO works in normal mode after safe mode!

Furthermore, until I ran in safe mode, I didn't see the quickfilter bar toggle button, and the quick filter bar itself was totally ineffective (not working). Now the toggle button is there, and the filter works.

Any clues why?

Comment 8

[Ludovic Hirlimann [:Usul]]

something got borked somewhere and was restored because of the use of safemode. if you have your previous locastore.rdf file that might help ? have you been running the extension - before the toolbar made it into core TB ?

Comment 9

[Rimas Kudelis [use needinfo to ping]]

No, I don't have the localstore.rdf, and I wasn't using the extension either. I was running stable series before.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Possibilities explaining the problem include:
- You were previously using the extension and the extension fought the built-in version.
- You tried some of the try builds which did something that caused the next bullet point...
- The tab de-persistence code has a bug in it that only happens with certain sessionstore.js scenarios.  

I would just keep this issue in mind in case we start getting more reported cases...

Comment 11

[Rimas Kudelis [use needinfo to ping]]

Ha! I just managed to repro by:
1) Quitting Lanikai
2) Launching Thunderbird 3.0.x
3) Quitting Thunderbird
4) Launching Lanikai
5) Closing the Welcome tab that appeared

That's it! Until I restarted Lanikai, I couldn't use the quickfilter bar. Same happens in safe mode, BTW. I'm pretty sure that the Welcome tab is the reason, because while I'm in it, I see the nonfunctional quickfilter toggle button, but after I close it, the button disappears.

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

anything in the error console?

Comment 13

[Rimas Kudelis [use needinfo to ping]]

Nothing relevant :(

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 avoid the need to generate synthetic tab monitor events

Thanks very much for the STR on this!

A slightly revised set of STR is:
0) have thunderbird not be running
1) delete your session.json file from your profile
2) edit user prefs so that the "mailnews.start_page_override.mstone" pref is not whatever it already is.

The general problem was that because the QuickFilterBar was getting initialized at an arbitrary time (using a "load" event) after the first tab was already opened, it was producing a synthetic tab notification somewhat unsafely.  It ended up lying to itself and claiming that the welcome page tab was the first 3-pane tab.  As such, the quick-filter bar would never be available on the first tab.  (There may be fallout for new tabs opened too because of errors with inheritance because a fundamental invariant would already have been violated; don't know.)

The fix is to explicitly initialize the quick filter bar with the rest of its brethren so it can avoid generating synthetic events.  (It is possible, of course, to generate safe synthetic events, but why add more code when you don't have to?)

This would be pretty hard to test realistically in mozmill without giving it its own test directory with just the single test.  Since thunderbird startup times are not fast, I think that's more expensive than justified given that this patch fundamentally simplifies the logic so the buggy situation can no longer arise.

Comment 15

[Mark Banner (:standard8)]

Checked in to trunk:
http://hg.mozilla.org/comm-central/rev/fbb7edba8ed5

c-1.9.2:
http://hg.mozilla.org/releases/comm-1.9.2/rev/eea8cb36da17

3.1 beta 2 branch for build 2 of beta 2:
http://hg.mozilla.org/releases/comm-1.9.2/rev/0f8f9c6d052c