User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:22.214.171.124) Gecko/20100401 Firefox/3.6.3 Build Identifier: Hello, Following bug 522761, I would like to add the possibility to manage Archive at semester and quarter level. Patch is included. Mozmill will follow. Reproducible: Always
Created attachment 441347 [details] [diff] [review] Semester and Quarter Archive Hello, Here is the patch to take care of archive level at semester level and quarter level. Tested. Does not break previous way of working. Patch is taking also care of the namespace problem with Inbox on bug 522761 I will add mozmill tests later on.
(In reply to comment #1) > Created an attachment (id=441347) [details] > Semester and Quarter Archive Thanks for the patch, as you can see at https://developer.mozilla.org/en/comm-central#Requirements you'll need to set a review request flag to get your patch reviewed. If you do change the UI you'll also need to set a UI review request.
Hello Ludovic, I know thta but as mozmill tests are not yet included I prefer to wait a bit before requesting review. What do you think? Kind Regards
(In reply to comment #3) > Hello Ludovic, > > I know thta but as mozmill tests are not yet included I prefer to wait a bit > before requesting review. > What do you think? Wait for complete patch + tests yes. I wasn't sure so I gave you the docs ;-)
Created attachment 441506 [details] [diff] [review] Full Patch with semiannually and qauterly archive with mozmill tests Hello, Here is the full patch. I don't know why I have still some changes for files I did not touch for this bug. I haev an issue with my hg but I have done hg pull and hg update and hg commit before creating the diff but still no changes. Nevertheless this should applies correctly. Kind Regards
Comment on attachment 441506 [details] [diff] [review] Full Patch with semiannually and qauterly archive with mozmill tests I think this would be better done as an extension.
Comment on attachment 441506 [details] [diff] [review] Full Patch with semiannually and qauterly archive with mozmill tests minusing based on that...
Hello David, I had another idea. Replace the granularity integer by a string of 4 characters allowing to have something like 1.YSQM saying ok I want my archives to be organized with (Y)yearly,(S) semi annually, (Q) quaterly, (M) monthly folders 2.YM saying ok I want my archives to be organized with yearly, monthly folders etc... Do you think it is a valid idea. I think it will bring great flexibility on the archive feature of TB Kind Regards
Christophe, if you do this as an extension, you can try out whatever ideas you like. You could experiment with using nsIMsgIncomingServer's get/set CharValue method to set a string property describing the archive structure, and your extension could read that string property and implement the archive granularity described by the string.