561700 - Permagreenorange: 8 (unnoticed) failures in "test_jQuery.html | ajax module" in every mochitest-2 run

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Phil Ringnalda (:philor)]

Thanks to our failure to check in bug 559839, we didn't notice that ever since the TraceMonkey merge Saturday afternoon (http://hg.mozilla.org/mozilla-central/rev/759a2a19f8d3 and friends), every single mozilla-central mochitest-2 run has had eight failures, e.g.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272251503.1272252005.18919.gz
Linux mozilla-central opt test mochitests-2/5 on 2010/04/25 20:11:43
s: moz2-linux-slave01

1588 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: $.ajax - dataType html - Check if script was evaluated for datatype html expected: foo actual: undefined
1589 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: $.ajax - dataType html - Check if script src was evaluated for datatype html expected: bar actual: null
1590 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: $.ajax - dataType html - Expected 5 assertions, but 3 were run
1620 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: load(String, Function) - check scripts - Check if script evaluation has modified DOM expected: foo actual:
1621 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: load(String, Function) - check scripts - Check if script was evaluated after load expected: foo actual: undefined
1622 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: load(String, Function) - check scripts - Check if script src was evaluated after load expected: bar actual: null
1623 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: load(String, Function) - check scripts - Check if script evaluation has modified DOM expected: bar actual:
1624 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/jquery/test_jQuery.html | ajax module: load(String, Function) - check scripts - Expected 7 assertions, but 5 were run

They also show up (not as orange, but in the brief log) in TraceMonkey Mo2/Md2, so a slow and tiresome trip back in time in tbpl should show when it first started failing.

Comment 1

[Phil Ringnalda (:philor)]

First failure is in http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1271916039.1271917257.22901.gz from http://hg.mozilla.org/tracemonkey/rev/35c25547a135 - bug 560358

Comment 2

[Andreas Gal :gal]

sayrer, I am not opposed to backing out the patch while I work on a fix, your call

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I backed out the patch on mozilla-central.
http://hg.mozilla.org/mozilla-central/rev/2968d19b0165

Comment 4

[Andreas Gal :gal]

Thanks roc.

Comment 5

[Andreas Gal :gal]

Both tests use match() and those are the only tests that use match. That's a pretty good starting point:

test("$.ajax - dataType html", function() {
	expect(5);
        stop();

        foobar = null;
        testFoo = undefined;

        var verifyEvaluation = function() {
          equals( testFoo, "foo", 'Check if script was evaluated for datatype html' );
          equals( foobar, "bar", 'Check if script src was evaluated for datatype html' );
          start();
        };

        $.ajax({
          dataType: "html",
          url: url("data/test.html"),
          success: function(data) {
                $("#ap").html(data);
            ok( data.match(/^html text/), 'Check content for datatype html' );
	    setTimeout(verifyEvaluation, 600);
          }
        });
});

test("load(String, Function) - check scripts", function() {
        expect(7);
        stop();
        window.testFoo = undefined;
        window.foobar = null;
	var verifyEvaluation = function() {
                equals( foobar, "bar", 'Check if script src was evaluated after load' );
                equals( $('#ap').html(), 'bar', 'Check if script evaluation has modified DOM');
                 start();
        };
        $('#first').load(url('data/test.html'), function() {
                ok( $('#first').html().match(/^html text/), 'Check content after loading html' );
	        equals( $('#foo').html(), 'foo', 'Check if script evaluation has modified DOM');
                equals( testFoo, "foo", 'Check if script was evaluated after load' );
                setTimeout(verifyEvaluation, 600);
        });
});

Comment 6

[David Mandelin [:dmandelin]]

AFAICT this was fixed by backing out, and then the offending patch was corrected and relanded.