The default bug view has changed. See this FAQ.

Port Bug 551505 [Fix context of RestoreDocument_proxy] to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.88 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 441459 [details] [diff] [review]
patch

From parent bug:

Right now RestoreDocument_proxy is added as a listener for the load event, so
that it can refill form data. However it's added directly, as opposed to every
other event listener adding SS and then calling a method. So the context is
weird when looking at the code. `this` is not SessionStore, it's the browser
object.

This has worked fine, but in doing probing work for bug 550967, I needed access
to the SessionStore `this`, but couldn't get it without creating a global or
attaching it to the tab, which is hacky.
Attachment #441459 - Flags: superreview?(neil)
Attachment #441459 - Flags: review?(neil)

Updated

7 years ago
Attachment #441459 - Flags: superreview?(neil)
Attachment #441459 - Flags: superreview+
Attachment #441459 - Flags: review?(neil)
Attachment #441459 - Flags: review+
(Assignee)

Comment 1

7 years ago
Pushed: http://hg.mozilla.org/comm-central/rev/c0df81ab60c4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a1
You need to log in before you can comment on or make changes to this bug.