Last Comment Bug 561723 - Port Bug 551505 [Fix context of RestoreDocument_proxy] to SeaMonkey
: Port Bug 551505 [Fix context of RestoreDocument_proxy] to SeaMonkey
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a1
Assigned To: Misak Khachatryan
:
Mentors:
Depends on: 551505
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-26 03:57 PDT by Misak Khachatryan
Modified: 2010-04-26 04:52 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (5.88 KB, patch)
2010-04-26 03:57 PDT, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Splinter Review

Description Misak Khachatryan 2010-04-26 03:57:54 PDT
Created attachment 441459 [details] [diff] [review]
patch

From parent bug:

Right now RestoreDocument_proxy is added as a listener for the load event, so
that it can refill form data. However it's added directly, as opposed to every
other event listener adding SS and then calling a method. So the context is
weird when looking at the code. `this` is not SessionStore, it's the browser
object.

This has worked fine, but in doing probing work for bug 550967, I needed access
to the SessionStore `this`, but couldn't get it without creating a global or
attaching it to the tab, which is hacky.
Comment 1 Misak Khachatryan 2010-04-26 04:52:22 PDT
Pushed: http://hg.mozilla.org/comm-central/rev/c0df81ab60c4

Note You need to log in before you can comment on or make changes to this bug.