562097 - Change persona 'custom license' to 'All rights reserved'

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement, P5)

Description

[Ryan Doherty (:rdoherty)]

Restricted licensed personas currently say 'custom license' which isn't very descriptive. Better wording would be 'All rights reserved'.

Comment 1

[Fred Wenzel [:wenzel]]

I think this is caused by there not being any license data in the preview database (i.e. the database fields are there, but they are all NULL). Likewise for daily users.

Comment 2

[Jeff Balogh (:jbalogh)]

You just need to change the text in amo/__init__.py

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> You just need to change the text in amo/__init__.py

That will affect add-ons with real custom licenses too.

Comment 4

[Wil Clouser [:clouserw]]

Attachment: local patch to keep things spicy!

This is because personas don't have versions but it was FKing to the versions table.  Here is a patch that fixes it.

Comment 5

[Jeff Balogh (:jbalogh)]

Comment on attachment 446526 [details] [diff] [review]
local patch to keep things spicy!

r- based on IRC conversations not recorded anywhere.

Comment 6

[Wil Clouser [:clouserw]]

http://pastebin.mozilla.org/726304 fixes this bug, but it breaks our tests (that's right, I ran the test suite) because django can't create the FK relationship.  I've tried adding db_index, but it runs indexes (sqlindexes) after creation (sql) so that doesn't work either.

Comment 7

[Wil Clouser [:clouserw]]

Attachment: fix

Alright, I'm adding the patch that fixes this here.  I think we're running into a Django bug here, so I reopened it on their end and we'll see:  http://code.djangoproject.com/ticket/12421#comment:3

In the mean time, this isn't critical so I'm kicking it out of 5.11.

Comment 8

[Jeff Balogh (:jbalogh)]

This will be fixed by bug 602034.  I gave metrics the wrong instructions for their metadata imports since license were so wacky.

Comment 9

[Jeff Balogh (:jbalogh)]

Fixed in bug 602034.