562322 - Overeager test filename detection

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Markus Stange [:mstange]]

Attachment: use ... | THIS PART | ...

Today there was the following test failure somewhere:

26181 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug515401.html | document base when insert base with href before existing - got "http://mochi.test:8888/tests/content/base/test/base5/", expected "http://mochi.test:8888/tests/content/base/test/base6/"

There's no bug filed for test_bug515401.html, so processLine looked at the next token with slashes and ended up with '",' as the filename. What followed was a huge lists with orange bugs that have a quotation mark in their summary.

Ehsan, were there any special cases you had in mind when you wrote the line
 $tokens = explode(" ", $line);
?
It looks to me like the test path is always in the second part that's separated with |. I've made a patch that uses that fact.

Comment 1

[(no longer active)]

Comment on attachment 442073 [details] [diff] [review]
use ... | THIS PART | ...

Looks sane.  I tried to remember why I tokenized based on a space, but couldn't.  I think I was just being silly!

Comment 2

[Markus Stange [:mstange]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/426b8d527f9b