Work around bug 549931, display empty address rather than completely incorrect header for 3.1 beta 2

RESOLVED FIXED in Thunderbird 3.1b2

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.1b2

Firefox Tracking Flags

(blocking-thunderbird3.1 beta2+, thunderbird3.1 beta2-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 442526 [details] [diff] [review]
Proposed fix

Bug 549931 discovered that an address of "undisclosed-recipients: ;" can mean we don't update the header and we just display the previously viewed header, which can be very confusing to the user.

When we hit that case extractHeaderAddressMailboxes current throws NS_ERROR_OUT_OF_MEMORY, therefore I'm proposing a well-placed try/catch to work around it for 3.1 beta 2 and just set the To string to the empty string. This then at least means we display a semi-relevant header.

Of course, for final, we'll fix bug 549931 in some manner, which will give us back the correct display and we can remove this workaround.

Tested with the testcase on bug 549931, also put "undisclosed-recipients: ;" on a Cc line, and that didn't change either.
Attachment #442526 - Flags: review?(bienvenu)
(Assignee)

Comment 1

9 years ago
Note: I'm planning on only landing this on the 3.1 branch so it is picked up in 3.1 nightles and for beta 2. Bug 549931 can handle the proper fix for trunk + final.

Comment 2

9 years ago
Created attachment 442544 [details] [diff] [review]
fix clearing of old header

this works a bit better for me - we still show an empty to: header, but that's better than showing the prev to field. r=me, for your part of the prev patch (Modulo the alert stuff which I already reviewed :-))
(Assignee)

Comment 3

9 years ago
Comment on attachment 442544 [details] [diff] [review]
fix clearing of old header

That's better, although as clarkbw hasn't looked at the alert service changes, I won't land them yet.
Attachment #442544 - Flags: review+
Attachment #442544 - Flags: approval-thunderbird3.1+
(Assignee)

Updated

9 years ago
Attachment #442526 - Attachment is obsolete: true
Attachment #442526 - Flags: review?(bienvenu)
(Assignee)

Comment 4

9 years ago
Checked in to 1.9.2 and the 3.1 beta 2 relbranch:

http://hg.mozilla.org/releases/comm-1.9.2/rev/8932dbfe9bfd
http://hg.mozilla.org/releases/comm-1.9.2/rev/445885daedf8

(not checking in on trunk, bug 549931 will handle the full fix).
Status: NEW → RESOLVED
Last Resolved: 9 years ago
status-thunderbird3.1: --- → beta2-fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.