562786 - Work around bug 549931, display empty address rather than completely incorrect header for 3.1 beta 2

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Mark Banner (:standard8)]

Attachment: Proposed fix

Bug 549931 discovered that an address of "undisclosed-recipients: ;" can mean we don't update the header and we just display the previously viewed header, which can be very confusing to the user.

When we hit that case extractHeaderAddressMailboxes current throws NS_ERROR_OUT_OF_MEMORY, therefore I'm proposing a well-placed try/catch to work around it for 3.1 beta 2 and just set the To string to the empty string. This then at least means we display a semi-relevant header.

Of course, for final, we'll fix bug 549931 in some manner, which will give us back the correct display and we can remove this workaround.

Tested with the testcase on bug 549931, also put "undisclosed-recipients: ;" on a Cc line, and that didn't change either.

Comment 1

[Mark Banner (:standard8)]

Note: I'm planning on only landing this on the 3.1 branch so it is picked up in 3.1 nightles and for beta 2. Bug 549931 can handle the proper fix for trunk + final.

Comment 2

[David :Bienvenu]

Attachment: fix clearing of old header

this works a bit better for me - we still show an empty to: header, but that's better than showing the prev to field. r=me, for your part of the prev patch (Modulo the alert stuff which I already reviewed :-))

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 442544 [details] [diff] [review]
fix clearing of old header

That's better, although as clarkbw hasn't looked at the alert service changes, I won't land them yet.

Comment 4

[Mark Banner (:standard8)]

Checked in to 1.9.2 and the 3.1 beta 2 relbranch:

http://hg.mozilla.org/releases/comm-1.9.2/rev/8932dbfe9bfd
http://hg.mozilla.org/releases/comm-1.9.2/rev/445885daedf8

(not checking in on trunk, bug 549931 will handle the full fix).