Closed
Bug 562916
Opened 15 years ago
Closed 15 years ago
Only display contribute button for add-ons that have contributions enabled
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: tchung, Assigned: mossop)
References
Details
(Whiteboard: [AddonsRewriteTestday][rewrite])
Attachments
(2 files)
|
2.56 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
|
1.99 KB,
patch
|
Details | Diff | Splinter Review |
We dont need a contribute button for plugins details. There's no support for that it seems on AMO, so it shouldnt be there on the plugins details page.
Repro:
1) install nightly Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre
2) have a few plugins installed
3) open about:addons > plugins > choose a plugin like Flash > and double click it
4) Verify the "Contribute" button should be removed or hidden for plugins. We dont ask users to Contribute to plugins on AMO.
Expected:
- no contribute button for plugins section
|
Reporter | |
Updated•15 years ago
|
Whiteboard: [AddonsRewriteTestday]
Blocks: 550048
Whiteboard: [AddonsRewriteTestday] → [AddonsRewriteTestday][rewrite]
|
Assignee | |
Updated•15 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•15 years ago
|
||
This is true for all add-ons really.
blocking2.0: --- → beta1+
Summary: Remove Contribute button for plugins details page → Only display contribute button for add-ons that have contributions enabled
|
|
Assignee | |
Updated•15 years ago
|
blocking2.0: beta1+ → final+
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → dtownsend
|
|
Assignee | |
Comment 2•15 years ago
|
||
Fixed by bug 562902
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
|
|
Assignee | |
Comment 3•15 years ago
|
||
Except not actually fixed properly
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•15 years ago
|
||
Because I used the wrong property name we went too far and never showed the contribution section
Attachment #473729 -
Flags: review?(bmcbride)
|
||
Updated•15 years ago
|
Attachment #473729 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
|
|
Assignee | |
Comment 6•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100922 Firefox/4.0b7pre by using Dom Inspector and Adblock Plus.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•