563071 - Implement "print" and "set" commands in asdb shell debugger

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Mike Morearty]

It would be helpful for our QE team to have the "set" and "print" commands available in asdb, the command-line debugger (the one you get when you specify -d).

Comment 1

[Mike Morearty]

Attachment: patch

Comment 2

[Mike Morearty]

Attachment: patch

Fixed a few things in the previous patch:

- Removed a debugging line that I had left in accidentally
- print and set now work correctly when getting or setting properties on dynamic objects -- e.g. if you say "print foo.bar", and foo is an instance of a dynamic class, and foo.bar has not yet been defiend, then it will now print "undefined"; and "set foo.bar=3" will also work.
- print now correctly finds globals such as Number, e.g. "print Number.MAX_VALUE"

Comment 3

[Rick Reitmaier]

Comment on attachment 443201 [details] [diff] [review]
patch

Nice!  

1082 should probably contain at least an assert, possibly an error message...
 // what should we do with setters? functions?

Comment 4

[Mike Morearty]

An assert or error message wouldn't be appropriate here -- it isn't an error to see setters or functions at this point in the code.  We are iterating over all of the object's traits, so there will be setters and functions; we deliberately ignore them.  The comment was meant to indicate that I was pondering whether it would be good for the debugger to display them somehow rather than just ignoring them.

I'll change the comment to be a little more clear.

Comment 5

[Mike Morearty]

Pushed: http://hg.mozilla.org/tamarin-redux/rev/f11149c872db