559967 - (tamarin-debugging) Improve Tamarin debugging and diagnostic facilities

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Rick Reitmaier]

Debugging tamarin bugs can be very laborious and often requires significant effort in building up a custom environment to support features that could just as easily be rolled into a debug or even release-debugger build.

Some examples:
  - dumping name,offset pairs of members for a given ScriptObject at a gdb prompt.
  - controlling which function are jit'd 

As these efforts are quite diverse and represent multiple 'features' this bug serves as a tracking bug any work in this area.

Comment 1

[Rick Reitmaier]

Attachment: ver 1

Patch that modifies verifier output to print status of notNull bit in a more consistent fashion, using the '~' character to represent the state of this bit.

Comment 2

[Edwin Smith]

Comment on attachment 451158 [details] [diff] [review]
ver 1

now that the suffix is the same either way, the code could be simplified:

add if (!t || ...) to the second if, and delete the first one completely


         Traits* t = v.traits;
         PrintWriter& out = core->console;
         out << t;
         if (!t || !t->isNumeric() && t != BOOLEAN_TYPE && t != NULL_TYPE && t != VOID_TYPE)
             out << (v.notNull ? "~" : "");

Comment 3

[Rick Reitmaier]

I noticed that we still need to have an if (!t) {} else {} since we output '*' when t is null and compiler barfs if PrintWriter is passed 2 types ala out << t ? t : "*".   We could some trickery to make it all happen but probably not worth it and anyway the resulting code didn't look much better in my eyes, so I checked in the original patch.

http://hg.mozilla.org/tamarin-redux/rev/be1f59904cff

Comment 4

[Edwin Smith]

I assumed that ... << (Traits*) 0 << ... would work, because the other day I noticed in PrintWriter.cpp, we have:

        PRINT_STAR_OPERATOR_SUPPORT(Traits,"*")

If it's not for auto-converting a null Traits* to "*", then what's it for?

Anyway, its a nit.

Comment 5

[Rick Reitmaier]

Ohhh good point;  missed that sorry.

Comment 6

[Rick Reitmaier]

pushed http://hg.mozilla.org/tamarin-redux/rev/70abd6230c3b

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.