563076 - Minimum width for pane sidebar to prevent confusion in add-ons manager

Status: VERIFIED WONTFIX

(Toolkit :: Add-ons Manager, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Implement minimum width for pane sidebar in add-ons manager to prevent confusion.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Blair, do we wanna cover this together with bug 553469?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #1)
> Blair, do we wanna cover this together with bug 553469?

I'd like Boriss's input on this first (see bug 553469 comment 6), but assuming that is the solution we want, then it makes sense to keep this bug, and mark bug 553469 as WONTFIX, rather than change the meaning of it.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Alright, we're taking this approach. 

This patch also fixes the ID of the left pane (which was previously "right-pane"), and saves/restores the width of the left pane (sadly, persist/localstore doesn't seem to work in tabs).

Comment 4

[Robert Strong (they/them - no direct email)]

Neil, Firefox will be adding the add-ons manager to a tab and will likely add other UI in tabs in the future. I see you've had discussions regarding using persists in content previously in the newsgroups and wanted to get your insight into what can be done for this use case. Thanks

Comment 5

[[e-mail]]

An unfortunate side effect of bug 329677 is that persist only works on nsIURLs. But about: URIs aren't nsIURLs. So nothing gets persisted. (Presumably nobody noticed that about:config no longer persists its sort attributes. If only the warning screen had used persistence, then maybe someone would have noticed...)

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 443568 [details] [diff] [review]
Patch v1

Mossop, though it appears there is no way to use persists in this UI atm I'd prefer not persisting until a better solution for persists is created other than using prefs. What do you think?

Comment 7

[Dave Townsend [:mossop]]

(In reply to comment #5)
> An unfortunate side effect of bug 329677 is that persist only works on nsIURLs.
> But about: URIs aren't nsIURLs. So nothing gets persisted. (Presumably nobody
> noticed that about:config no longer persists its sort attributes. If only the
> warning screen had used persistence, then maybe someone would have noticed...)

Is this something that can be fixed?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yes; redesign persistance to not suck (e.g. use a string pair, not a string, as the key).

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 443568 [details] [diff] [review]
Patch v1

Let's just do the min width for now and sort out persistence separately if we can get the platform to cooperate.

What is the max-width needed for?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As spoken with Blair this patch will also fix the wrong naming of the left-pane. It's id right now is "right-pane". We should fix it before any add-on author starts to create overlays for the add-ons manager. We also need this fixed for our Mozmill tests. Blair will work on a new patch by tomorrow.

Comment 11

[Dave Townsend [:mossop]]

Not blocking. Blair, you have r=me on just renaming the ID if you want to get that checked in anyway.

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #11)
> Not blocking. Blair, you have r=me on just renaming the ID if you want to get
> that checked in anyway.

Thanks, just did exactly that in bug 569797.

Comment 13

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This is not needed anymore, since its no longer resizable.