563168 - Blocklist service warns of bad add-ons, but nothing is listed.

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100501 Minefield/3.7a5pre RTSE/1.2.0.20100406
Build Identifier: 

I'm using one of the recent trunk nightlies with the new Extension Manager stuff.

I just had the Blocklist warning box pop up, saying that some of my add-ons are
known to cause stability or security problems.

But the list was empty.

Looking at the actual list( https://www.mozilla.com/en-US/blocklist/ ), I think
my version of the Java Deployment Toolkit actually is in the blocklist, but the
warning for bad add-ons was empty.

After Restarting Firefox, it doesn't look like anything was actually disabled.

Reproducible: Always

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

It has now come up twice for me.

I'm not sure what steps to reproduce.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Have seen the same problem last week but forgot to file it. Easy steps to reproduce are:

1. Install the Viewpoint Media Player plugin (see URL)
2. Wait a while or trigger the blocklisting check

Comment 3

[Dave Townsend [:mossop]]

Should have tested this properly with the new UI. The blocklist dialog uses some bindings that used to be in extensions.xml that got removed. The testcase verifies that the dialog is loaded and the correct things passed, but not that the UI displays correctly.

http://hg.mozilla.org/projects/addonsmgr/rev/8f225766b6db

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This pulls the necessary bindings into a new file (removing the unnecessary addon-name-version).

Also copies across the old needed entities. I don't think we need to rename these as they are in a new file but need to check that.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 443762 [details] [diff] [review]
patch rev 1

If there is a need to change the entity names in this case then IMO the process is borked! r=me

Comment 6

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/52b0f3e17183

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100514 Minefield/3.7a5pre

Comment 8

[Dave Townsend [:mossop]]

I think we can cover this automatically but I think we should have a manual test of the blocklist too if we don't already have one.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

(In reply to comment #8)
> I think we can cover this automatically but I think we should have a manual
> test of the blocklist too if we don't already have one.

Right now we only have a test for installing an blocklisted extension. I would assume it will be enough the blocklist for extensions? If that's fine I will create a similar test like https://litmus.mozilla.org/show_test.cgi?id=10853

Comment 10

[Dave Townsend [:mossop]]

(In reply to comment #9)
> (In reply to comment #8)
> > I think we can cover this automatically but I think we should have a manual
> > test of the blocklist too if we don't already have one.
> 
> Right now we only have a test for installing an blocklisted extension. I would
> assume it will be enough the blocklist for extensions? If that's fine I will
> create a similar test like https://litmus.mozilla.org/show_test.cgi?id=10853

Yes that should be fine.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Litmus test has been added:
https://litmus.mozilla.org/show_test.cgi?id=15309