563813 - Localization issue for menu "Status" in "New event/New task" dialogs

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Decathlon]

The menu Options->Status in "New event" dialog and the drop-down box "Status" in "New task" dialog have the same strings for two entries: "Not specified" and "Cancelled", but some languages need different strings because the entries refer to "New event" and "New task" that could have different genders (e.g. in Italian language "Nuovo evento" and "Nuova attività" are masculine and feminine genders respectively).

Comment 1

[Decathlon]

Attachment: patch - v1

This patch adds two strings that are used in the drop-down menu "Status" (dialog "New Task") instead of the original strings.
I hope it could be reviewed before the string freeze. Sorry for this "extra" work Philipp ;-)

Comment 2

[Stefan Sitter [:ssitter]]

Nit: Shouldn't it be "Canceled" instead of "Cancelled" for en-US locale?

Comment 3

[Decathlon]

(In reply to comment #2)
> Nit: Shouldn't it be "Canceled" instead of "Cancelled" for en-US locale?

You are right Stefan:
http://dictionary.reference.com/browse/cancel
Do I have to change the strings in .dtd and .properties files? It seems there are 3 strings to change.

Comment 4

[Decathlon]

Attachment: patch - v2

Trying to modify the others strings from "Cancelled" to "Canceled", I've found out that the original issue (only for the status "Cancelled") also occurs  in the tooltip of events and tasks in the calendar view, in the unifinder and in the task list in task view, i.e. there is a unique string for "cancelled" status for events and tasks. I attach a new patch that fixes these cases too.
I haven't changed the word "Cancelled" in the strings name and in every comment.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 443861 [details] [diff] [review]
patch - v2

Looks good, r=philipp

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/eafc6d2f2a8e>
-> FIXED

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/06e29a1b0949>
-> FIXED

Comment 8

[Simon Vaillancourt]

Reopening because calendar-summary-dialog still uses the label: newevent.status.cancelled.label , so that dialog is currently broken

Comment 9

[Simon Vaillancourt]

note that bug 391673 also broke that dialog, I think it would make things simpler if we could track the fix for all regressions in that dialog here so I will leave the other bug closed.

Comment 10

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix Regression - v1

This patch fixes both regressions. Note most of those changes are whitespace
changes to align the xml

Comment 11

[Simon Vaillancourt]

Looks good r=simon

Comment 12

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/0f01091253c9>
-> FIXED

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/27673b78a229>
-> FIXED

Comment 14

[Decathlon]

Sorry, I reopen again because with the last fix there is again the localization issue in the summary dialog (status "cancelled" has the same string for events and tasks). I attach a working patch to fix it.
I was writing a patch but Philipp has been faster ;-)

Comment 15

[Decathlon]

Attachment: Fix a second regression

I hope it's everything fine this time.
I would ask a question: under what circumstance the menulist "item-alarm" should appear in the dialog?
If the calendar is read only and the event has a reminder, should the menulist be present when the Summary dialog appears?
To test it and seeing the menulist, I set the calendar read-only and momentarily removed the NOT operator before window.readOnly http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-summary-dialog.js#118 .

Comment 16

[Simon Vaillancourt]

> I would ask a question: under what circumstance the 
> menulist "item-alarm" should appear in the dialog?

This dialog is not only shown when the calendar is read-only but when the item is an invitation in a scheduling calendar, in which case the user can set a participation status and also an alarm.

Comment 17

[Decathlon]

OK Simon, thanks for your explanation.

Comment 18

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 444197 [details] [diff] [review]
Fix a second regression


>         for (var i = 0; i < statusRow.childNodes.length; i++) {
>             if (statusRow.childNodes[i].getAttribute("status") == status) {
>                 statusRow.removeAttribute("hidden");
>+                if (status == "CANCELLED" && cal.isToDo(item)) {
>+                    i++;
>+                }
A comment would be nice here, I'll add one.

r=philipp

Comment 19

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/6f195902e307>
-> FIXED

Comment 20

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/084aa9c32762>
-> FIXED