Show a message when the screen orientation is locked/unlocked

VERIFIED FIXED

Status

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Details

Attachments

(4 attachments)

Step to reproduce:
 * go to any site
 * change the orientation of the device
 * try to do Ctrl + shit + O
 * switch the orientation again

Actual results:
 * if you failed doing Ctrl + shift + O the browser will be switched again

Expected results:
 * A feedback when I do the shortcut
Created attachment 443841 [details] [diff] [review]
Patch

If the bug is valid in a UX term, I guess the strings needs to be revised.
Assignee: nobody → 21
Attachment #443841 - Flags: ui-review?(madhava)
Attachment #443841 - Flags: review?(mark.finkle)
Comment on attachment 443841 [details] [diff] [review]
Patch


>+alertLockScreen=Screen
>+alertLockScreen.enabled=Screen orientation is locked
>+alertLockScreen.disabled=Screen orientation is unlocked

I would drop the "Screen" part from the message. It's a bit redundant with the title:
 alertLockScreen.enabled=Orientation is locked

Also, use .locked and .unlocked instead of .enabled and .disabled

I can make those changes when I land.

Madhava, do we want this for 1.1? String freeze is soon.
Attachment #443841 - Flags: review?(mark.finkle) → review+
Sounds like we want this for Fennec 2.0, but with different strings.

> http://www.flickr.com/photos/madhava_work/4583896847/

I don't think we do anything different for alerts in portrait.
Attachment #443841 - Flags: review+ → review-
Comment on attachment 443841 [details] [diff] [review]
Patch

Hell, I can change the strings when I land :)
Attachment #443841 - Flags: review- → review+
Comment on attachment 443841 [details] [diff] [review]
Patch

Madhava has given his OK
Attachment #443841 - Flags: ui-review?(madhava) → ui-review+
pushed with string changes to m-b:
http://hg.mozilla.org/mobile-browser/rev/0596318de8f9

This is not going into m-1.1
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
ON build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre

I'm seeing the "screen unlocked" dialog when the screen is actually locked and "screen locked when the screen is not locked.

Alternatively, with this patch anytime I go into portrait mode, the tab sidebar is shown and the url bar is displaced. I'm going to re-open and request how you'd like to handle this situation. Either one of two scenarios: 

1. don't back-out the patch, file bugs for both issues

2. Back-out the patch and fix both issues on the next revision.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 444103 [details] [diff] [review]
followup

There was a little inversion during the strings change.
Attachment #444103 - Flags: review?
(In reply to comment #12)
> ON build:
> 
> I'm seeing the "screen unlocked" dialog when the screen is actually locked and
> "screen locked when the screen is not locked.

Good catch!

> Alternatively, with this patch anytime I go into portrait mode, the tab sidebar
> is shown and the url bar is displaced. I'm going to re-open and request how
> you'd like to handle this situation. Either one of two scenarios: 
> 

This is probably a side effect of the fact bug 564138 still exist on your build.
Attachment #444103 - Flags: review?(webapps) → review+
pushed followup to m-b:
http://hg.mozilla.org/mobile-browser/rev/05eb53701e0b
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100511 Namoroka/3.7a5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.