564134 - Show a message when the screen orientation is locked/unlocked

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Step to reproduce:
 * go to any site
 * change the orientation of the device
 * try to do Ctrl + shit + O
 * switch the orientation again

Actual results:
 * if you failed doing Ctrl + shift + O the browser will be switched again

Expected results:
 * A feedback when I do the shortcut

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

If the bug is valid in a UX term, I guess the strings needs to be revised.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshoot locked

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshoot unlocked

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 443841 [details] [diff] [review]
Patch


>+alertLockScreen=Screen
>+alertLockScreen.enabled=Screen orientation is locked
>+alertLockScreen.disabled=Screen orientation is unlocked

I would drop the "Screen" part from the message. It's a bit redundant with the title:
 alertLockScreen.enabled=Orientation is locked

Also, use .locked and .unlocked instead of .enabled and .disabled

I can make those changes when I land.

Madhava, do we want this for 1.1? String freeze is soon.

Comment 5

[Madhava Enros [:madhava]]

Perhaps like this?
http://www.flickr.com/photos/madhava_work/4583896847/

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #5)
> Perhaps like this?
> http://www.flickr.com/photos/madhava_work/4583896847/

Good for me.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like we want this for Fennec 2.0, but with different strings.

> http://www.flickr.com/photos/madhava_work/4583896847/

I don't think we do anything different for alerts in portrait.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 443841 [details] [diff] [review]
Patch

Needs a new patch

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 443841 [details] [diff] [review]
Patch

Hell, I can change the strings when I land :)

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 443841 [details] [diff] [review]
Patch

Madhava has given his OK

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with string changes to m-b:
http://hg.mozilla.org/mobile-browser/rev/0596318de8f9

This is not going into m-1.1

Comment 12

[Aakash Desai [:aakashd]]

ON build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre

I'm seeing the "screen unlocked" dialog when the screen is actually locked and "screen locked when the screen is not locked.

Alternatively, with this patch anytime I go into portrait mode, the tab sidebar is shown and the url bar is displaced. I'm going to re-open and request how you'd like to handle this situation. Either one of two scenarios: 

1. don't back-out the patch, file bugs for both issues

2. Back-out the patch and fix both issues on the next revision.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: followup

There was a little inversion during the strings change.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #12)
> ON build:
> 
> I'm seeing the "screen unlocked" dialog when the screen is actually locked and
> "screen locked when the screen is not locked.

Good catch!

> Alternatively, with this patch anytime I go into portrait mode, the tab sidebar
> is shown and the url bar is displaced. I'm going to re-open and request how
> you'd like to handle this situation. Either one of two scenarios: 
> 

This is probably a side effect of the fact bug 564138 still exist on your build.

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed followup to m-b:
http://hg.mozilla.org/mobile-browser/rev/05eb53701e0b

Comment 16

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100511 Namoroka/3.7a5pre Fennec/2.0a1pre