564138 - Shift+Ctrl+o lock the screen _AND_ resize the window

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

On device this can result into annoying situation where the screen is lock on portrait but the window is resize to 800x480.

I think this one should block 1.1.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I think we should change shift+ctrl+o as a cheat code on desktop, but also make sure the cheat code only works on desktop. For now that would mean changing the key from "o" to something else because it is a conflict and wrapping the cheat code in "#ifndef MOZ_PLATFORM_MAEMO" so it won't be active on device - ever.

We can add ANDROID to the list when needed

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 443845 [details] [diff] [review]
Patch

I'll wrap the code with the MOZ_PLATFORM_MAEMO check when I land the patch.

Also, I don't think the original patch was landed on 1.1, only trunk.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

In my opinion debug code, even if it is convenient like Shift+Ctrl+o, has nothing to do in a release product. :)

(In reply to comment #2)
> (From update of attachment 443845 [details] [diff] [review])
> I'll wrap the code with the MOZ_PLATFORM_MAEMO check when I land the patch.
> 
> Also, I don't think the original patch was landed on 1.1, only trunk.

Nice, I didn't get that. Sorry for the "should block 1.1" alarm!

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> In my opinion debug code, even if it is convenient like Shift+Ctrl+o, has
> nothing to do in a release product. :)

We could address this for all of the debug keypress code

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/e3532a836bda

Comment 6

[Aakash Desai [:aakashd]]

Hm, I commented in bug 564134 that anytime I switch to portrait mode,the tab sidebar is shown and the url bar is displaced on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre



I thought that bug was cause of this issue, but it probably has more to do with this bug.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #6)
> Hm, I commented in bug 564134 that anytime I switch to portrait mode,the tab
> sidebar is shown and the url bar is displaced on build:
> 
> Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre)
> Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre
> 
> 
> 
> I thought that bug was cause of this issue, but it probably has more to do with
> this bug.

Yeah, it is this one but they are closely related. I don't know why this patch didn't appear in the last nightly but works on my custom build on desktop.
I'd like to wait till tomorrow for the next nightly to see if something was wrong for the first one.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #7)
> (In reply to comment #6)
> > Hm, I commented in bug 564134 that anytime I switch to portrait mode,the tab
> > sidebar is shown and the url bar is displaced on build:
> > 
> > Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre)
> > Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre
> > 
> > 
> > 
> > I thought that bug was cause of this issue, but it probably has more to do with
> > this bug.
> 
> Yeah, it is this one but they are closely related. I don't know why this patch
> didn't appear in the last nightly but works on my custom build on desktop.
> I'd like to wait till tomorrow for the next nightly to see if something was
> wrong for the first one.

WFM, now.

Aakash?

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

No response for one month. Closing!(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Hm, I commented in bug 564134 that anytime I switch to portrait mode,the tab
> > > sidebar is shown and the url bar is displaced on build:
> > > 
> > > Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre)
> > > Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre
> > > 
> > > 
> > > 
> > > I thought that bug was cause of this issue, but it probably has more to do with
> > > this bug.
> > 
> > Yeah, it is this one but they are closely related. I don't know why this patch
> > didn't appear in the last nightly but works on my custom build on desktop.
> > I'd like to wait till tomorrow for the next nightly to see if something was
> > wrong for the first one.
> 
> WFM, now.
> 
> Aakash?

No response for one month. Closing!

Comment 10

[Aakash Desai [:aakashd]]

Yep, works for me on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a6pre) Gecko/2010621 Namoroka/3.7a6pre Fennec/2.0a1pre